caicancai commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625250855
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -3072,24 +3072,33 @@ private SqlDialect nonOrdinalDialect() {
sql(query).d
caicancai commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625250855
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -3072,24 +3072,33 @@ private SqlDialect nonOrdinalDialect() {
sql(query).d
caicancai commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625250855
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -3072,24 +3072,33 @@ private SqlDialect nonOrdinalDialect() {
sql(query).d
fanluoo commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625399135
##
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##
@@ -109,6 +109,20 @@ public StarRocksSqlDialect(Context context) {
@Override publ
sonarcloud[bot] commented on PR #3810:
URL: https://github.com/apache/calcite/pull/3810#issuecomment-2146623481
## [](https://sonarclo
thadguidry opened a new pull request, #3810:
URL: https://github.com/apache/calcite/pull/3810
- fixes typo for time window example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
caicancai commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625250855
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -3072,24 +3072,33 @@ private SqlDialect nonOrdinalDialect() {
sql(query).d
YiwenWu commented on code in PR #3802:
URL: https://github.com/apache/calcite/pull/3802#discussion_r1623163032
##
core/src/main/java/org/apache/calcite/sql/validate/DelegatingScope.java:
##
@@ -297,8 +298,17 @@ protected void addColumnNames(
namespace = map.get(tableNam
YiwenWu commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625233958
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -3072,24 +3072,33 @@ private SqlDialect nonOrdinalDialect() {
sql(query).dia
sonarcloud[bot] commented on PR #3790:
URL: https://github.com/apache/calcite/pull/3790#issuecomment-2146416347
## [](https://sonarclo
YiwenWu commented on code in PR #3802:
URL: https://github.com/apache/calcite/pull/3802#discussion_r1625228313
##
core/src/main/java/org/apache/calcite/sql/validate/DelegatingScope.java:
##
@@ -297,8 +298,17 @@ protected void addColumnNames(
namespace = map.get(tableNam
mihaibudiu commented on PR #3809:
URL: https://github.com/apache/calcite/pull/3809#issuecomment-2146390793
No tests were affected because today casts to decimal values are noops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
This is an automated email from the ASF dual-hosted git repository.
xiong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new be9b860ebf [CALCITE-6424] Enable RLIKE function in M
NobiGo merged PR #3806:
URL: https://github.com/apache/calcite/pull/3806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apa
NobiGo commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625197913
##
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##
@@ -109,6 +109,20 @@ public StarRocksSqlDialect(Context context) {
@Override publi
NobiGo commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625193002
##
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##
@@ -109,6 +109,20 @@ public StarRocksSqlDialect(Context context) {
@Override publi
mihaibudiu commented on code in PR #3790:
URL: https://github.com/apache/calcite/pull/3790#discussion_r1625193179
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -738,30 +739,32 @@ void testCastToExactNumeric(CastType castType,
SqlOperatorFixture f)
NobiGo commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625193002
##
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##
@@ -109,6 +109,20 @@ public StarRocksSqlDialect(Context context) {
@Override publi
mihaibudiu commented on code in PR #3790:
URL: https://github.com/apache/calcite/pull/3790#discussion_r1625190722
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java:
##
@@ -449,6 +449,35 @@ private Expression getConvertExpression(
return
mihaibudiu commented on PR #3797:
URL: https://github.com/apache/calcite/pull/3797#issuecomment-2146346062
this seems to be approved, can you squash the commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mihaibudiu commented on code in PR #3805:
URL: https://github.com/apache/calcite/pull/3805#discussion_r1625176508
##
core/src/main/java/org/apache/calcite/util/format/postgresql/DateStringFormatPattern.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation
mihaibudiu commented on code in PR #3794:
URL: https://github.com/apache/calcite/pull/3794#discussion_r1624900784
##
core/src/main/java/org/apache/calcite/sql/SqlIntervalQualifier.java:
##
@@ -445,6 +446,53 @@ public int getIntervalSign(String value) {
return sign;
}
+
sonarcloud[bot] commented on PR #3802:
URL: https://github.com/apache/calcite/pull/3802#issuecomment-2145902147
## [](https://sonarclo
mihaibudiu commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1624894858
##
babel/src/test/resources/sql/redshift.iq:
##
@@ -523,78 +523,78 @@ select deptno, ratio_to_report(sal) over (partition by
deptno) from emp;
!}
# STDDEV_POP
-
normanj-bitquill commented on code in PR #3802:
URL: https://github.com/apache/calcite/pull/3802#discussion_r1624837165
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -633,6 +633,7 @@ private boolean expandStar(List selectItems,
Set aliases,
caicancai commented on code in PR #3806:
URL: https://github.com/apache/calcite/pull/3806#discussion_r1624450724
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -974,12 +974,12 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding
operatorBin
caicancai commented on PR #3808:
URL: https://github.com/apache/calcite/pull/3808#issuecomment-2145173453
@YiwenWu If you have time, can you take a look? I remember that Starrocks
was adapted by you before.
--
This is an automated message from the Apache Git Service.
To respond to the mes
caicancai commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1624432755
##
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##
@@ -109,6 +109,20 @@ public StarRocksSqlDialect(Context context) {
@Override pu
NobiGo commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1624395500
##
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##
@@ -109,6 +109,20 @@ public StarRocksSqlDialect(Context context) {
@Override publi
fanluoo closed pull request #3807: [CALCITE-6426] When performing starrocks
dialect conversion for cast(xxx as int) and cast (xxx as bigint), it defaults
to using MySQL dialect
URL: https://github.com/apache/calcite/pull/3807
--
This is an automated message from the Apache Git Service.
To re
NobiGo commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1624043542
##
babel/src/test/resources/sql/redshift.iq:
##
@@ -523,78 +523,78 @@ select deptno, ratio_to_report(sal) over (partition by
deptno) from emp;
!}
# STDDEV_POP
-sele
zabetak commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1623942276
##
babel/src/test/resources/sql/redshift.iq:
##
@@ -523,78 +523,78 @@ select deptno, ratio_to_report(sal) over (partition by
deptno) from emp;
!}
# STDDEV_POP
-sel
32 matches
Mail list logo
