Re: [PR] [CALCITE-6434] JDBC adapter generates wrong SQL for Spark and Hive because it fails to quote an identifier containing '$' [calcite]

2024-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3820: URL: https://github.com/apache/calcite/pull/3820#issuecomment-2164166570 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

(calcite) branch main updated: [CALCITE-6434] JDBC adapter generates wrong SQL for Spark and Hive because it fails to quote an identifier containing '$'

2024-06-12 Thread xiong
This is an automated email from the ASF dual-hosted git repository. xiong pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 05923bf4db [CALCITE-6434] JDBC adapter generates wro

Re: [PR] [CALCITE-6434] JDBC adapter generates wrong SQL for Spark and Hive because it fails to quote an identifier containing '$' [calcite]

2024-06-12 Thread via GitHub
NobiGo merged PR #3820: URL: https://github.com/apache/calcite/pull/3820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apa

Re: [PR] Fix the druid json_object issue [calcite]

2024-06-12 Thread via GitHub
NobiGo commented on PR #3821: URL: https://github.com/apache/calcite/pull/3821#issuecomment-2164148570 @AlbericByte Please create a new issue in [JIRA](https://issues.apache.org/jira/browse/CALCITE). -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix the druid json_object issue [calcite]

2024-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3821: URL: https://github.com/apache/calcite/pull/3821#issuecomment-2164108821 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] Fix the druid json_object issue [calcite]

2024-06-12 Thread via GitHub
AlbericByte opened a new pull request, #3821: URL: https://github.com/apache/calcite/pull/3821 # Fix the druid json_object issue. # Description 1. Now in druid, we will construct the SqlFunction instance as following: ``` private static final SqlFunction SQL_FUNCTION = Ope

Re: [PR] [CALCITE-6426] Invalid unparse for INT and BIGINT in StarRocksDialect [calcite]

2024-06-12 Thread via GitHub
NobiGo merged PR #3808: URL: https://github.com/apache/calcite/pull/3808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apa

(calcite) branch main updated: [CALCITE-6426] Invalid unparse for INT and BIGINT in StarRocksDialect

2024-06-12 Thread xiong
This is an automated email from the ASF dual-hosted git repository. xiong pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 1079bcea97 [CALCITE-6426] Invalid unparse for INT an

Re: [PR] [CALCITE-6426] Invalid unparse for INT and BIGINT in StarRocksDialect [calcite]

2024-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3808: URL: https://github.com/apache/calcite/pull/3808#issuecomment-2162672452 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [CALCITE-6426] Invalid unparse for INT and BIGINT in StarRocksDialect [calcite]

2024-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3808: URL: https://github.com/apache/calcite/pull/3808#issuecomment-2162636399 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [CALCITE-6426] Invalid unparse for INT and BIGINT in StarRocksDialect [calcite]

2024-06-12 Thread via GitHub
fanluoo commented on code in PR #3808: URL: https://github.com/apache/calcite/pull/3808#discussion_r1636184761 ## core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java: ## @@ -19,14 +19,7 @@ import org.apache.calcite.avatica.util.TimeUnitRange; import org.