Re: [PR] [CALCITE-5756] Expand ProjectJoinRemoveRule to support inner join remove by the foreign-unique constraint in the catalog [calcite]

2024-07-11 Thread via GitHub
mihaibudiu commented on PR #3264: URL: https://github.com/apache/calcite/pull/3264#issuecomment-2224683145 This PR was approved, but never merged. What's the plan? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(calcite) branch main updated: [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp

2024-07-11 Thread mbudiu
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 374091b0a7 [CALCITE-6449] Enable PostgreSQL impleme

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

2024-07-11 Thread via GitHub
mihaibudiu merged PR #3833: URL: https://github.com/apache/calcite/pull/3833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite

Re: [PR] [CALCITE-6462] VolcanoPlanner internal valid may throw exception when… [calcite]

2024-07-11 Thread via GitHub
sonarcloud[bot] commented on PR #3851: URL: https://github.com/apache/calcite/pull/3851#issuecomment-2224267096 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [CALCITE-6462] VolcanoPlanner internal valid may throw exception when… [calcite]

2024-07-11 Thread via GitHub
NobiGo commented on code in PR #3851: URL: https://github.com/apache/calcite/pull/3851#discussion_r1674917200 ## core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java: ## @@ -982,11 +982,17 @@ void propagateCostImprovements(RelNode rel) { if (!relNode.g

Re: [PR] [CALCITE-6462] VolcanoPlanner internal valid may throw exception when… [calcite]

2024-07-11 Thread via GitHub
sonarcloud[bot] commented on PR #3851: URL: https://github.com/apache/calcite/pull/3851#issuecomment-2224236338 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [CALCITE-6454] Implement array comparison operators [calcite]

2024-07-11 Thread via GitHub
NobiGo commented on PR #3852: URL: https://github.com/apache/calcite/pull/3852#issuecomment-2224235956 @normanj-bitquill 1) I find different data source has different behaviour about NULL value: ``` spark-sql (default)> select array(1,2)>array(1,null); true Time taken:

Re: [PR] [CALCITE-6466] add benchmark for SQL parser instantiation [calcite]

2024-07-11 Thread via GitHub
cyrilou242 commented on code in PR #3853: URL: https://github.com/apache/calcite/pull/3853#discussion_r1674756688 ## ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [CALCITE-6466] add benchmark for SQL parser instantiation [calcite]

2024-07-11 Thread via GitHub
cyrilou242 commented on code in PR #3853: URL: https://github.com/apache/calcite/pull/3853#discussion_r1674753689 ## ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [CALCITE-6466] add benchmark for SQL parser instantiation [calcite]

2024-07-11 Thread via GitHub
cyrilou242 commented on code in PR #3853: URL: https://github.com/apache/calcite/pull/3853#discussion_r1674747392 ## ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [CALCITE-6466] add benchmark for SQL parser instantiation [calcite]

2024-07-11 Thread via GitHub
cyrilou242 commented on code in PR #3853: URL: https://github.com/apache/calcite/pull/3853#discussion_r1674746023 ## ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [CALCITE-6466] add benchmark for SQL parser instantiation [calcite]

2024-07-11 Thread via GitHub
cyrilou242 commented on code in PR #3853: URL: https://github.com/apache/calcite/pull/3853#discussion_r1674719255 ## ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [CALCITE-6466] add benchmark for SQL parser instantiation [calcite]

2024-07-11 Thread via GitHub
cyrilou242 commented on PR #3853: URL: https://github.com/apache/calcite/pull/3853#issuecomment-2223972517 > Thanks for the benchmark @cyrilou242 ! I left some small comments but looks good. > > The purpose of this benchmark is different from that in [CALCITE-1012](https://issues.apa

Re: [PR] CALCITE-6310: Add REGEXP_REPLACE function (enabled in PostgreSQL library) [calcite]

2024-07-11 Thread via GitHub
normanj-bitquill commented on code in PR #3801: URL: https://github.com/apache/calcite/pull/3801#discussion_r1674707220 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -563,12 +563,58 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding oper

Re: [PR] CALCITE-6310: Add REGEXP_REPLACE function (enabled in PostgreSQL library) [calcite]

2024-07-11 Thread via GitHub
normanj-bitquill commented on code in PR #3801: URL: https://github.com/apache/calcite/pull/3801#discussion_r1674706865 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -563,12 +563,58 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding oper

Re: [PR] CALCITE-6310: Add REGEXP_REPLACE function (enabled in PostgreSQL library) [calcite]

2024-07-11 Thread via GitHub
normanj-bitquill commented on code in PR #3801: URL: https://github.com/apache/calcite/pull/3801#discussion_r1674706234 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -563,12 +563,58 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding oper

Re: [PR] CALCITE-6310: Add REGEXP_REPLACE function (enabled in PostgreSQL library) [calcite]

2024-07-11 Thread via GitHub
normanj-bitquill commented on PR #3801: URL: https://github.com/apache/calcite/pull/3801#issuecomment-2223905686 Updated with the following behaviour: ### Amazon Redshift * Can provide only two arguments. The replacement string will be the empty string. https://docs.aws.amaz

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

2024-07-11 Thread via GitHub
normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1674648077 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1690,22 +1690,40 @@ private static RelDataType deriveTypeMapFromEntries(SqlO

Re: [PR] [CALCITE-6454] Implement array comparison operators [calcite]

2024-07-11 Thread via GitHub
normanj-bitquill commented on PR #3852: URL: https://github.com/apache/calcite/pull/3852#issuecomment-2223846601 > the natural question is whether this works for other recursive types, such as `int array array`... @mihaibudiu I'm not sure. This PR currently handles arrays and rows. Th

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

2024-07-11 Thread via GitHub
normanj-bitquill commented on PR #3833: URL: https://github.com/apache/calcite/pull/3833#issuecomment-2223756122 The commits have been squashed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

2024-07-11 Thread via GitHub
sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/calcite/pull/3833#issuecomment-2223740736 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] CALCITE-6310: Add REGEXP_REPLACE function (enabled in PostgreSQL library) [calcite]

2024-07-11 Thread via GitHub
sonarcloud[bot] commented on PR #3801: URL: https://github.com/apache/calcite/pull/3801#issuecomment-2223702244 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

(calcite) branch main updated: [CALCITE-6388] PsTableFunction throws NumberFormatException when the 'user' column has spaces

2024-07-11 Thread asolimando
This is an automated email from the ASF dual-hosted git repository. asolimando pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 8581dba433 [CALCITE-6388] PsTableFunction throw

Re: [PR] [CALCITE-6388] PsTableFunction throws NumberFormatException when the … [calcite]

2024-07-11 Thread via GitHub
asolimando merged PR #3777: URL: https://github.com/apache/calcite/pull/3777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite

Re: [PR] [CALCITE-6388] PsTableFunction throws NumberFormatException when the … [calcite]

2024-07-11 Thread via GitHub
sonarcloud[bot] commented on PR #3777: URL: https://github.com/apache/calcite/pull/3777#issuecomment-2223050330 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [CALCITE-6388] PsTableFunction throws NumberFormatException when the … [calcite]

2024-07-11 Thread via GitHub
sonarcloud[bot] commented on PR #3777: URL: https://github.com/apache/calcite/pull/3777#issuecomment-951164 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [CALCITE-6388] PsTableFunction throws NumberFormatException when the … [calcite]

2024-07-11 Thread via GitHub
asolimando commented on PR #3777: URL: https://github.com/apache/calcite/pull/3777#issuecomment-932790 The force push is just to change the latest commit message (forgot that it must now start with an uppercase letter), no impact -- This is an automated message from the Apache Git Ser

Re: [PR] [CALCITE-1012] add benchmark for SQL parser instantiation [calcite]

2024-07-11 Thread via GitHub
zabetak commented on code in PR #3853: URL: https://github.com/apache/calcite/pull/3853#discussion_r1673961753 ## ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [CALCITE-6435] SqlToRel conversion of IN expressions may lead to incorrect simplifications [calcite]

2024-07-11 Thread via GitHub
kgyrtkirk merged PR #3835: URL: https://github.com/apache/calcite/pull/3835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.

(calcite) branch main updated: [CALCITE-6435] SqlToRel conversion of IN expressions may lead to incorrect simplifications

2024-07-11 Thread kgyrtkirk
This is an automated email from the ASF dual-hosted git repository. kgyrtkirk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 73846cceb1 [CALCITE-6435] SqlToRel conversion of

(calcite) branch main updated: [CALCITE-6460] SortRemoveConstantKeysRule fails with AssertionError due to mismatched collation on resulting Sort

2024-07-11 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new a98508fd36 [CALCITE-6460] SortRemoveConstantKeysRu

Re: [PR] [CALCITE-6460] SortRemoveConstantKeysRule fails with AssertionError due to mismatched collation on resulting Sort [calcite]

2024-07-11 Thread via GitHub
rubenada merged PR #3850: URL: https://github.com/apache/calcite/pull/3850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.a

[PR] [CALCITE-1012] add benchmark for SQL parser instantiation [calcite]

2024-07-11 Thread via GitHub
cyrilou242 opened a new pull request, #3853: URL: https://github.com/apache/calcite/pull/3853 This benchmark will help to measure the progress on the discussion here: https://lists.apache.org/thread/xw35sdy1w1k8lvn1q1lr7xb93bkj0lpq As of today the parsers instantiation is pretty slow an