mihaibudiu commented on code in PR #3950:
URL: https://github.com/apache/calcite/pull/3950#discussion_r1744827988
##
core/src/test/resources/sql/measure.iq:
##
@@ -179,6 +179,53 @@ from empm;
!ok
+# [CALCITE-6559] LogicalCorrelate Type mismatch
+# Occurs when AVG measure is
julianhyde opened a new pull request, #3950:
URL: https://github.com/apache/calcite/pull/3950
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
suibianwanwank commented on code in PR #3949:
URL: https://github.com/apache/calcite/pull/3949#discussion_r1744762621
##
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##
@@ -1910,11 +1910,15 @@ private boolean needNewSubQuery(
return true;
NobiGo closed pull request #2616: [CALCITE-4871] CAST a literal to DECIMAL type
return wrong result
URL: https://github.com/apache/calcite/pull/2616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
NobiGo merged PR #3943:
URL: https://github.com/apache/calcite/pull/3943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apa
ChengJie1053 commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2330421969
> Ok, thanks for reviewing the code for me
Ok, thanks for reviewing the code for me, I will change the code
--
This is an automated message from the Apache Git Service.
T
ChengJie1053 commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2330409466
> @ChengJie1053 Thanks for your contribution, can you confirm that these
functions give the same results in some boundary tests?
>
> In my experience, this is difficult to guar
julianhyde commented on code in PR #3947:
URL: https://github.com/apache/calcite/pull/3947#discussion_r1744660968
##
core/src/main/java/org/apache/calcite/util/Variant.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
julianhyde commented on code in PR #3947:
URL: https://github.com/apache/calcite/pull/3947#discussion_r1744667636
##
core/src/main/java/org/apache/calcite/util/rtti/RuntimeTypeInformation.java:
##
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
normanj-bitquill commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1744280709
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -613,6 +613,59 @@ public static SqlCall stripSeparator(SqlCall call) {
public stat
sonarcloud[bot] commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2329764096
## [](https://sonarclo
sonarcloud[bot] commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2329656162
## [](https://sonarclo
julianhyde commented on PR #3946:
URL: https://github.com/apache/calcite/pull/3946#issuecomment-2329643745
This PR feels too small. In calcite, a commit that is merged to main is
generally at the grain of a jira case, and a jira case is a bug or a feature.
Commits merged to main are rarely
mihaibudiu commented on code in PR #3949:
URL: https://github.com/apache/calcite/pull/3949#discussion_r1744185603
##
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##
@@ -1910,11 +1910,15 @@ private boolean needNewSubQuery(
return true;
}
julianhyde commented on code in PR #3946:
URL: https://github.com/apache/calcite/pull/3946#discussion_r1744180721
##
core/src/test/resources/sql/measure.iq:
##
@@ -26,6 +26,136 @@ from emp;
!update
+create view empm_comm as
+select *, avg(sal) as measure avg_sal, avg(comm)
julianhyde commented on code in PR #3946:
URL: https://github.com/apache/calcite/pull/3946#discussion_r1744179376
##
core/src/test/resources/sql/measure.iq:
##
@@ -26,6 +26,136 @@ from emp;
!update
+create view empm_comm as
Review Comment:
I wouldn't create a view for j
sonarcloud[bot] commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2329610011
## [](https://sonarclo
julianhyde commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2329500646
Can you move (or at least copy) that description to the Jira case? Jira
cases are our feature specifications. Minimal features thatI would like to see
specified:
* How VARIANT inte
sonarcloud[bot] commented on PR #3945:
URL: https://github.com/apache/calcite/pull/3945#issuecomment-2329229610
## [](https://sonarclo
sonarcloud[bot] commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2328822096
## [](https://sonarclo
ChengJie1053 opened a new pull request, #3948:
URL: https://github.com/apache/calcite/pull/3948
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
caicancai commented on PR #3944:
URL: https://github.com/apache/calcite/pull/3944#issuecomment-2328457910
> This should be an issue in JIRA. Do you have a JIRA account? You can ask
for one, it's free. https://issues.apache.org
>
> I was thinking to file your text as an issue, but I co
22 matches
Mail list logo
