[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-12-06 Thread GitBox
JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r1041636188 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java: ## @@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory typeFa

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-12-05 Thread GitBox
JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r1040264729 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java: ## @@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory typeFa

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-07-11 Thread GitBox
JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r918551024 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -2936,7 +2936,7 @@ values (10, 'Fred')]]>

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-07-11 Thread GitBox
JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r918550342 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -2885,7 +2885,7 @@ LogicalTableModify(table=[[CATALOG, SALES, EMPDEFAULTS]],

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-07-11 Thread GitBox
JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r918549135 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -2897,7 +2897,7 @@ LogicalTableModify(table=[[SALES, EMPDEFAULTS]], operatio