JiajunBernoulli commented on code in PR #2860: URL: https://github.com/apache/calcite/pull/2860#discussion_r929471146
########## core/src/main/java/org/apache/calcite/sql/dialect/FireboltSqlDialect.java: ########## @@ -196,4 +197,18 @@ public FireboltSqlDialect(Context context) { } } } + + @Override public void unparseSqlIntervalLiteral(SqlWriter writer, + SqlIntervalLiteral literal, int leftPrec, int rightPrec) { + SqlIntervalLiteral.IntervalValue interval = + literal.getValueAs(SqlIntervalLiteral.IntervalValue.class); + writer.keyword("INTERVAL"); + writer.print("'"); + if (interval.getSign() == -1) { + writer.print("-"); + } + writer.literal(interval.getIntervalLiteral()); + writer.print(interval.getIntervalQualifier().toString()); Review Comment: `toString` is AnsiSqlDialect.DEFAULT. I prefer to use `interval.getIntervalQualifier().unparse(writer, leftPrec, rightPrec);` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org