[GitHub] [calcite] abhishek-das-gupta commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

2022-10-18 Thread GitBox
abhishek-das-gupta commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r997862622 ## core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java: ## @@ -624,6 +624,29 @@ private void checkDate(RexLiteral literal) {

[GitHub] [calcite] abhishek-das-gupta commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

2022-10-15 Thread GitBox
abhishek-das-gupta commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r996345727 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -1258,6 +1259,26 @@ private static String toSql(RelNode root,

[GitHub] [calcite] abhishek-das-gupta commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

2022-10-09 Thread GitBox
abhishek-das-gupta commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r990811601 ## core/src/main/java/org/apache/calcite/rex/RexBuilder.java: ## @@ -1355,10 +1356,14 @@ public RexNode makeIn(RexNode arg, List ranges) { if

[GitHub] [calcite] abhishek-das-gupta commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

2022-10-08 Thread GitBox
abhishek-das-gupta commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r990604610 ## core/src/main/java/org/apache/calcite/rex/RexBuilder.java: ## @@ -1355,10 +1356,14 @@ public RexNode makeIn(RexNode arg, List ranges) { if

[GitHub] [calcite] abhishek-das-gupta commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

2022-10-07 Thread GitBox
abhishek-das-gupta commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r989827399 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -1252,6 +1253,26 @@ private static String toSql(RelNode root,