asolimando commented on pull request #2592:
URL: https://github.com/apache/calcite/pull/2592#issuecomment-954770821
Just rebased on master, tests are green, can we merge @vlsi @NobiGo ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
asolimando commented on pull request #2592:
URL: https://github.com/apache/calcite/pull/2592#issuecomment-953916531
The test failure seems unrelated (from the changes from master and given the
scope of the current PR) but I don't manage to see the log details, I think the
container just
asolimando commented on pull request #2592:
URL: https://github.com/apache/calcite/pull/2592#issuecomment-953100170
Never mind, I have added the description because there was a conflict to fix
with master (gradle.properties).
--
This is an automated message from the Apache Git Service.
asolimando commented on pull request #2592:
URL: https://github.com/apache/calcite/pull/2592#issuecomment-952730479
On a second thought, there are some important info in the PR description
that I think should be in the git description as well, could you add it when
merging the PR?
asolimando commented on pull request #2592:
URL: https://github.com/apache/calcite/pull/2592#issuecomment-952638170
Thank you both for the review, I have squashed the commits and updated the
commit message, once the test are over I think it can be merged.
--
This is an automated message
asolimando commented on pull request #2592:
URL: https://github.com/apache/calcite/pull/2592#issuecomment-951151210
> By the way. The commit info should be same as
[CALCITE-4768](https://issues.apache.org/jira/browse/CALCITE-4768) in Jira.
Yes, you are right, I generally have the
