asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1286888938
@Aitozi, can you squash the commits into a single one having as commit
message `[CALCITE-5264] HintStrategy rule exclusion does not match innermost
rels`? As soon as this is done I am
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1282762416
The PR LGTM, I will merge by the end of this week if there will be no
objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1275935388
> Hi @asolimando can you help me here:
>
> when I develop on the calcite, I found it's not easy to conform its
checkstyle, especially the indentation. I have tried
>
> *
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1274946950
> @asolimando Thanks for your comments, I have addressed them. And rebase on
the latest master force pushed.
Thanks @Aitozi for addressing the comments so fast!
However,
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1274816052
Apart from few minor comments, the PR looks good to me. I have checked the
original PR and the discussion there, it makes sense to me too to check all
rels, but since I am not very
