[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-10-21 Thread GitBox
dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1001563447 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java: ## @@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types, List

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-10-21 Thread GitBox
dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1001561672 ## core/src/main/codegen/templates/Parser.jj: ## @@ -243,6 +243,17 @@ public class ${parser.class} extends SqlAbstractParserImpl return SqlStmtList();

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-10-20 Thread GitBox
dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1000675480 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java: ## @@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types, List

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-06-03 Thread GitBox
dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r888741749 ## core/src/main/codegen/templates/Parser.jj: ## @@ -238,6 +238,39 @@ public class ${parser.class} extends SqlAbstractParserImpl return SqlStmtList();

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-06-03 Thread GitBox
dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r888740933 ## core/src/main/java/org/apache/calcite/config/CalciteConnectionConfig.java: ## @@ -110,4 +110,6 @@ public interface CalciteConnectionConfig extends

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

2022-05-29 Thread GitBox
dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r884313553 ## core/src/main/codegen/templates/Parser.jj: ## @@ -238,6 +238,39 @@ public class ${parser.class} extends SqlAbstractParserImpl return SqlStmtList();