guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-100304
Thanks for the reminder, I get it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-997816971
@zabetak I feel the pr is ready, can you review it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-993234327
@zabetak, I added a custom Jekyll hook plugin that will check before
generating html to add a div parent to the table. I feel good, if you have
time to help check the ui e
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-993109505
@zabetak, thanks for the tip, I got it, I'll see how to customize the
behavior of the kramdown HTML converter later
--
This is an automated message from the Apache Git Se
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-990603226
Two new commits have been added
14b2bd3 Added syntax highlighting to sql statements in materialized_views.md
edef563 Center the table content horizontally to display t
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-990599647
@zabetak Setting table display to block has the side effect of not filling
the full width of a table with less content.
Like this
![image](https://user-images.githubu
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-989976407
> @guiyanakuang The changes about code wrapping and scrollability are a good
idea but they are more useful if the apply everywhere. After playing a bit and
resizing the win
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-989822777
@zabetak, thanks for approving to this pr, I am reading the source code of
calcite and look forward to the subsequent community collaboration.
--
This is an automated mes