[GitHub] [calcite] hujianhong commented on pull request #3292: [CALCITE-5807] Add SUBSTRING_INDEX function (enabled in Spark library)

hujianhong commented on PR #3292: URL: https://github.com/apache/calcite/pull/3292#issuecomment-1645186283 @ILuffZhe Can you help me find out what is the reason of the CI task failed? The CI log information seem not match to my PR. ![image](https://github.com/apache/calcite/assets/206621

[GitHub] [calcite] hujianhong commented on pull request #3292: [CALCITE-5807] Add SUBSTRING_INDEX function (enabled in Spark library)

hujianhong commented on PR #3292: URL: https://github.com/apache/calcite/pull/3292#issuecomment-1645022639 > There are some specific rules for commit message after [c0e6ba2](https://github.com/apache/calcite/commit/c0e6ba264b3e522010a982ed35de9f3dd03be6af). Could you please amend yours so I

[GitHub] [calcite] hujianhong commented on pull request #3292: [CALCITE-5807] Add SUBSTRING_INDEX function (enabled in Spark library)

hujianhong commented on PR #3292: URL: https://github.com/apache/calcite/pull/3292#issuecomment-1644892032 > Hi @hujianhong , left some comments. One small tip: before the final squash and rebase, please don't force push your commit. It helps other reviewers to see the differences. I