[GitHub] [calcite] itiels commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

2022-11-28 Thread GitBox
itiels commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1329304370 HI @libenchao, Sorry for the late reply. I agree with your conclusion, however I prefer to do that in a separate PR if it's ok with you. -- This is an automated message from t

[GitHub] [calcite] itiels commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

2022-11-11 Thread GitBox
itiels commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1311502368 Thanks @libenchao for the review. I've fixed the comment. As for `PERCENTILE_CONT`, based on conversation with Julian in the Jira ticket, there is nothing to be done. Is t