[GitHub] [calcite] jamesstarr commented on pull request #2639: [CALCITE-4929] Implement default getDef() methods in MetadataHandler interfaces

jamesstarr commented on pull request #2639: URL: https://github.com/apache/calcite/pull/2639#issuecomment-991220351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [calcite] jamesstarr commented on pull request #2639: [CALCITE-4929] Implement default getDef() methods in MetadataHandler interfaces

jamesstarr commented on pull request #2639: URL: https://github.com/apache/calcite/pull/2639#issuecomment-991484772 All of calcites instances would still return value, and previously all of their instances would have had to have an implementation. You can not break down stream code by

[GitHub] [calcite] jamesstarr commented on pull request #2639: [CALCITE-4929] Implement default getDef() methods in MetadataHandler interfaces

jamesstarr commented on pull request #2639: URL: https://github.com/apache/calcite/pull/2639#issuecomment-991220351 > @jacques-n, it is used in ReflectiveRelMetadataProvider to support deprecated behavior, so no refactoring or minimal refactoring is required. You could just have i

[GitHub] [calcite] jamesstarr commented on pull request #2639: [CALCITE-4929] Implement default getDef() methods in MetadataHandler interfaces

jamesstarr commented on pull request #2639: URL: https://github.com/apache/calcite/pull/2639#issuecomment-990675884 Have you consider adding a default implementation directly to handler interface and deprecating the method? -- This is an automated message from the Apache Git Service. T