jnturton commented on PR #2698:
URL: https://github.com/apache/calcite/pull/2698#issuecomment-1092587512
@asereda-gs I agree that the right design is for the application to request
the freeing of resources. An hour or so ago I started work on making Schema
implement AutoCloseable with a
jnturton commented on PR #2698:
URL: https://github.com/apache/calcite/pull/2698#issuecomment-1092407150
> I understand that you want to properly manage resource lifecycle. Is there
a reason you can't share existing `ElasticsearchSchema` ?
>
> Is there a way in your environment to
jnturton commented on PR #2698:
URL: https://github.com/apache/calcite/pull/2698#issuecomment-1091493446
Hi @ILuffZhe, is there anything more I should do here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jnturton commented on pull request #2698:
URL: https://github.com/apache/calcite/pull/2698#issuecomment-1073253010
@ILuffZhe @zabetak, sorry about the long delay. Please see this alternative
approach which aims to both address the leak and make efficient use of
RestClient.
--
This is
jnturton commented on pull request #2698:
URL: https://github.com/apache/calcite/pull/2698#issuecomment-1024449415
@ILuffZhe @zabetak, a colleague of mine has raised a concern that recreating
the RestClient for every request, as I've done in this iteration, might
negatively affect
