[GitHub] [calcite] julianhyde commented on a diff in pull request #3000: [CALCITE-5423] Implement TIMESTAMP_DIFF function (compatible with BigQuery)

2022-12-12 Thread GitBox
julianhyde commented on code in PR #3000: URL: https://github.com/apache/calcite/pull/3000#discussion_r1046138609 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7534,6 +7534,10 @@ private static void checkArrayConcatAggFuncFails(SqlOperatorFixture

[GitHub] [calcite] julianhyde commented on a diff in pull request #3000: [CALCITE-5423] Implement TIMESTAMP_DIFF function (compatible with BigQuery)

2022-12-11 Thread GitBox
julianhyde commented on code in PR #3000: URL: https://github.com/apache/calcite/pull/3000#discussion_r1045344772 ## core/src/main/java/org/apache/calcite/sql/fun/SqlTimestampDiffFunction.java: ## @@ -94,7 +105,10 @@ private static RelDataType inferReturnType2(SqlOperatorBindin