[GitHub] [calcite] korlov42 commented on pull request #2623: CALCITE-4913 Correlated variables in a select list are not deduplicated

2022-02-14 Thread GitBox
korlov42 commented on pull request #2623: URL: https://github.com/apache/calcite/pull/2623#issuecomment-1039169099 Hi, @zabetak! Sorry for pushing, but is there any chance you'll find the time to help me get this PR done? -- This is an automated message from the Apache Git Service. To

[GitHub] [calcite] korlov42 commented on pull request #2623: CALCITE-4913 Correlated variables in a select list are not deduplicated

2022-01-28 Thread GitBox
korlov42 commented on pull request #2623: URL: https://github.com/apache/calcite/pull/2623#issuecomment-1024010004 Hi, @zabetak! Seems like 10 days have passed. Now it's my turn to be unavailable for next 10 days, but I really hope you'll find time to review this. -- This is an

[GitHub] [calcite] korlov42 commented on pull request #2623: CALCITE-4913 Correlated variables in a select list are not deduplicated

2022-01-14 Thread GitBox
korlov42 commented on pull request #2623: URL: https://github.com/apache/calcite/pull/2623#issuecomment-1013229352 @vlsi, I've added a `@Deprecated` on the Project's constructor. This highlighted a bunch of missed places (primarily, adapters). So all of them are fixed now, I suppose.

[GitHub] [calcite] korlov42 commented on pull request #2623: CALCITE-4913 Correlated variables in a select list are not deduplicated

2021-12-13 Thread GitBox
korlov42 commented on pull request #2623: URL: https://github.com/apache/calcite/pull/2623#issuecomment-992519038 > The sad thing is Calcite users would get similar issues: they would get wrong results/wrong plans, and nobody would know the reason. Before this patch, they could get