[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

2022-11-02 Thread GitBox
libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1012476387 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(

[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

2022-11-02 Thread GitBox
libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1011870569 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(

[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

2022-10-30 Thread GitBox
libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1008826577 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(

[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

2022-10-25 Thread GitBox
libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1004346250 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(

[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

2022-10-24 Thread GitBox
libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1003909401 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(

[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

2022-10-22 Thread GitBox
libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1002623077 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(