libenchao commented on code in PR #2910: URL: https://github.com/apache/calcite/pull/2910#discussion_r981235738
########## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ########## @@ -6352,6 +6352,20 @@ private void checkLiteral2(String expression, String expected) { .withCalcite().ok(expectedCalciteX); } + /** Test case for + * <a href="https://issues.apache.org/jira/browse/CALCITE-5265">[CALCITE-5265] + * Select operator' parentheses should be same with Union operator</a>. */ + @Test void testInsertValueWithDynamicParams() { Review Comment: Are there any tests which cover what Julian has mentioned in the JIRA comment? ########## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ########## @@ -6352,6 +6352,20 @@ private void checkLiteral2(String expression, String expected) { .withCalcite().ok(expectedCalciteX); } + /** Test case for + * <a href="https://issues.apache.org/jira/browse/CALCITE-5265">[CALCITE-5265] + * Select operator' parentheses should be same with Union operator</a>. */ Review Comment: The comment should also be adapted according to the changes in JIRA title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org