[GitHub] [calcite] libenchao commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

2022-11-29 Thread GitBox
libenchao commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1330293444 @julianhyde Very thanks for the reminder  , I did plan to do that while merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] libenchao commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

2022-11-28 Thread GitBox
libenchao commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1329982053 I'm ok with finishing it to another separate issue. This PR now looks good to me. The CI failure seems unrelated, I'll merge it. -- This is an automated message from the Apache Git

[GitHub] [calcite] libenchao commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

2022-11-28 Thread GitBox
libenchao commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1329213773 @itiels Sorry to ping you. We plan to release 1.33 recently, it would be great if we can make it in this release. Do you have any comments about my last comment? -- This is an

[GitHub] [calcite] libenchao commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

2022-11-12 Thread GitBox
libenchao commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1312638552 > As for PERCENTILE_CONT, based on conversation with Julian in the Jira ticket, there is nothing to be done. I'm not sure about this conclusion, I've checked the SQL standard