[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-12 Thread GitBox
olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1068601759 ## babel/src/test/resources/sql/redshift.iq: ## @@ -1238,7 +1238,7 @@ select date_part(minute, time '02:08:01'); select date_part(minute, date '2009-01-01'); !ok !}

[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-10 Thread GitBox
olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1066431760 ## core/src/main/codegen/templates/Parser.jj: ## @@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : { } } + SqlIntervalQualifier TimeUnitOrNameFor

[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-09 Thread GitBox
olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1065256516 ## core/src/main/codegen/templates/Parser.jj: ## @@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : { } } + SqlIntervalQualifier TimeUnitOrNameFor

[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-09 Thread GitBox
olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1065115931 ## core/src/main/codegen/templates/Parser.jj: ## @@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : { } } + SqlIntervalQualifier TimeUnitOrNameFor

[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-09 Thread GitBox
olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1065125968 ## core/src/main/codegen/templates/Parser.jj: ## @@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : { } } + SqlIntervalQualifier TimeUnitOrNameFor

[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-09 Thread GitBox
olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1065115931 ## core/src/main/codegen/templates/Parser.jj: ## @@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : { } } + SqlIntervalQualifier TimeUnitOrNameFor

[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2022-12-20 Thread GitBox
olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1053806093 ## babel/src/test/resources/sql/redshift.iq: ## @@ -1238,7 +1238,7 @@ select date_part(minute, time '02:08:01'); select date_part(minute, date '2009-01-01'); !ok !}