[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-17 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1072911432 ## babel/src/test/resources/sql/big-query.iq: ## @@ -1097,12 +1097,74 @@ select unix_date(datetime '2008-12-25') as d; # # Return Data Type: DATE -select

[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-13 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1070146181 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4609,15 +4610,116 @@ SqlLiteral DateTimeLiteral() : } | { s = span(); } p = SimpleStringLiteral() { -

[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-13 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1070115107 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-13 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1069975023 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +