[GitHub] [calcite] vvysotskyi commented on a diff in pull request #3006: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

2022-12-27 Thread GitBox
vvysotskyi commented on code in PR #3006: URL: https://github.com/apache/calcite/pull/3006#discussion_r1057798342 ## core/src/main/java/org/apache/calcite/sql/SqlPivot.java: ## @@ -195,5 +197,17 @@ static class Operator extends SqlSpecialOperator { Operator(SqlKind kind) {

[GitHub] [calcite] vvysotskyi commented on a diff in pull request #3006: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

2022-12-23 Thread GitBox
vvysotskyi commented on code in PR #3006: URL: https://github.com/apache/calcite/pull/3006#discussion_r1056436172 ## core/src/main/java/org/apache/calcite/sql/SqlPivot.java: ## @@ -195,5 +197,17 @@ static class Operator extends SqlSpecialOperator { Operator(SqlKind kind) {

[GitHub] [calcite] vvysotskyi commented on a diff in pull request #3006: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

2022-12-20 Thread GitBox
vvysotskyi commented on code in PR #3006: URL: https://github.com/apache/calcite/pull/3006#discussion_r1053728428 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -6653,13 +6654,44 @@ private void checkLiteral2(String expression, String exp