[GitHub] [calcite] wnob commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-18 Thread GitBox
wnob commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1074030646 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] wnob commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-18 Thread GitBox
wnob commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1074027016 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4609,15 +4610,116 @@ SqlLiteral DateTimeLiteral() : } | { s = span(); } p = SimpleStringLiteral() { -