[GitHub] [calcite] zabetak commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

2022-09-06 Thread GitBox
zabetak commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r963555806 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,11 +67,24 @@ public class XmlFunctions { private static final ThreadLocal<@Nullable

[GitHub] [calcite] zabetak commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

2022-09-05 Thread GitBox
zabetak commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r962695246 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -215,6 +238,27 @@ private static String convertNodeToString(Node node) throws