zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-1007366791
Thanks for the PR @guiyanakuang , any improvement to the website is much
appreciated ;)
--
This is an automated message from the Apache Git Service.
To respond to the
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-1007366791
Thanks for the PR @guiyanakuang , any improvement to the website is much
appreciated ;)
--
This is an automated message from the Apache Git Service.
To respond to the
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-1006612543
General reminder: Please avoid rebasing when a review is in progress unless
you are requested to do so. Rebasing makes new changes harder to see. In
addition, when the
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-998217167
@guiyanakuang sure I will make another pass in the following days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-992416576
@guiyanakuang also a small tip: In the future try to keep PRs self contained
so that they can get merged easier. Various improvements here (e.g.,
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-992409154
> I think it is better to wrap a special div in the outer layer to deal with
this feature of horizontal scrolling.
@guiyanakuang You 're probably right I think the best
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-990008705
How "crowded" a table is does not depend only on the content but also on the
size of the screen/window/browser.
I did verify that changes seem to have the intended
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-989891958
@guiyanakuang The changes about code wrapping and scrollability are a good
idea but they are more useful if the apply everywhere. After playing a bit and
resizing the window I
