[GitHub] [calcite] zabetak commented on pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

2022-11-28 Thread GitBox
zabetak commented on PR #2937: URL: https://github.com/apache/calcite/pull/2937#issuecomment-1329217861 @rubenada Thanks for the reminder. I added an additional `DEFAULT` instance for the new `ZeroMaxRowsRuleConfig` and rebased against `main`. I will merge this once all tests are run. --

[GitHub] [calcite] zabetak commented on pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

2022-10-14 Thread GitBox
zabetak commented on PR #2937: URL: https://github.com/apache/calcite/pull/2937#issuecomment-1278688528 @rubenada I guess there are other rules which miss a `DEFAULT` config instance. The problem though may not be so serious in every case if rules are not declared as 'RelOptRule` but as a s