[GitHub] [calcite-avatica] joshelser commented on a diff in pull request #184: CALCITE-5327 Make SSL key-store type configurable

2022-10-25 Thread GitBox
joshelser commented on code in PR #184: URL: https://github.com/apache/calcite-avatica/pull/184#discussion_r1005046102 ## server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java: ## @@ -850,6 +875,9 @@ protected SslContextFactory.Server buildSSLContextFactory()

[GitHub] [calcite-avatica] joshelser commented on a diff in pull request #184: CALCITE-5327 Make SSL key-store type configurable

2022-10-21 Thread GitBox
joshelser commented on code in PR #184: URL: https://github.com/apache/calcite-avatica/pull/184#discussion_r1001885363 ## server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java: ## @@ -767,6 +771,27 @@ public Builder withTLS(File keystore, String