[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

2022-12-07 Thread GitBox
julianhyde commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1042567249 ## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

2022-12-07 Thread GitBox
julianhyde commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041977848 ## core/src/test/java/org/apache/calcite/avatica/util/DateAccessorTest.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

2022-12-06 Thread GitBox
julianhyde commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041634873 ## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foun