snuyanzin merged PR #3569:
URL: https://github.com/apache/calcite/pull/3569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mihaibudiu commented on PR #3569:
URL: https://github.com/apache/calcite/pull/3569#issuecomment-1981243084
No objections from me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
snuyanzin commented on PR #3569:
URL: https://github.com/apache/calcite/pull/3569#issuecomment-1980905984
@mihaibudiu since we are going to have a release soon I would merge this by
the end of this week
please let me know if you have any objections
--
This is an automated message from
sonarcloud[bot] commented on PR #3569:
URL: https://github.com/apache/calcite/pull/3569#issuecomment-1962229883
## [ {
mihaibudiu commented on code in PR #3569:
URL: https://github.com/apache/calcite/pull/3569#discussion_r1436583927
##
core/src/main/java/org/apache/calcite/sql/type/SqlTypeName.java:
##
@@ -309,7 +314,10 @@ public enum SqlTypeName {
* matches the given name, or throws {@link
mihaibudiu commented on code in PR #3569:
URL: https://github.com/apache/calcite/pull/3569#discussion_r1436582231
##
core/src/main/java/org/apache/calcite/sql/type/SqlTypeName.java:
##
@@ -65,12 +65,16 @@ public enum SqlTypeName {
DATE(PrecScale.NO_NO, false, Types.DATE,
mihaibudiu commented on code in PR #3569:
URL: https://github.com/apache/calcite/pull/3569#discussion_r1436581647
##
cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java:
##
@@ -192,6 +193,9 @@ private String translateMatch(RexNode condition) {
tanclary commented on code in PR #3569:
URL: https://github.com/apache/calcite/pull/3569#discussion_r1435825219
##
cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java:
##
@@ -192,6 +193,9 @@ private String translateMatch(RexNode condition) {
mihaibudiu commented on PR #3569:
URL: https://github.com/apache/calcite/pull/3569#issuecomment-1867088799
I have simplified the naming of the types, as suggested by @julianhyde in a
JIRA discussion for the uber-issue 208 that this PR is a part of:
sonarcloud[bot] commented on PR #3569:
URL: https://github.com/apache/calcite/pull/3569#issuecomment-1846161471
Kudos, SonarCloud Quality Gate passed! [