Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-21 Thread via GitHub
tanclary merged PR #3565: URL: https://github.com/apache/calcite/pull/3565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-21 Thread via GitHub
sonarcloud[bot] commented on PR #3565: URL: https://github.com/apache/calcite/pull/3565#issuecomment-1866979251 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-21 Thread via GitHub
tanclary commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1434526658 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -8878,51 +8878,106 @@ private void testCurrentDateFunc(Pair pair) { } @Test void

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-21 Thread via GitHub
julianhyde commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1434504495 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -8878,51 +8878,106 @@ private void testCurrentDateFunc(Pair pair) { } @Test

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-21 Thread via GitHub
sonarcloud[bot] commented on PR #3565: URL: https://github.com/apache/calcite/pull/3565#issuecomment-1866428817 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-20 Thread via GitHub
tanclary commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1432903605 ## core/src/main/java/org/apache/calcite/sql/dialect/SnowflakeSqlDialect.java: ## @@ -36,6 +39,30 @@ public SnowflakeSqlDialect(Context context) {

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-20 Thread via GitHub
tanclary commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1432903188 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java: ## @@ -73,7 +73,9 @@ public enum SqlLibrary { POSTGRESQL("p", "postgresql"), /** A collection

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-05 Thread via GitHub
julianhyde commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1416677533 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -6557,6 +6557,34 @@ private void checkLiteral2(String expression, String

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-05 Thread via GitHub
julianhyde commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1416675477 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java: ## @@ -73,7 +73,9 @@ public enum SqlLibrary { POSTGRESQL("p", "postgresql"), /** A

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-05 Thread via GitHub
Anthrino commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1416376206 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java: ## @@ -73,7 +73,9 @@ public enum SqlLibrary { POSTGRESQL("p", "postgresql"), /** A collection

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-05 Thread via GitHub
Anthrino commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1416363480 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java: ## @@ -73,7 +73,9 @@ public enum SqlLibrary { POSTGRESQL("p", "postgresql"), /** A collection

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-05 Thread via GitHub
tanclary commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1416348525 ## core/src/main/java/org/apache/calcite/sql/dialect/SnowflakeSqlDialect.java: ## @@ -36,6 +39,30 @@ public SnowflakeSqlDialect(Context context) {

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-05 Thread via GitHub
olivrlee commented on code in PR #3565: URL: https://github.com/apache/calcite/pull/3565#discussion_r1416346102 ## core/src/main/java/org/apache/calcite/sql/dialect/SnowflakeSqlDialect.java: ## @@ -36,6 +39,30 @@ public SnowflakeSqlDialect(Context context) {

Re: [PR] [CALCITE-6156] Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries) [calcite]

2023-12-05 Thread via GitHub
tanclary commented on PR #3565: URL: https://github.com/apache/calcite/pull/3565#issuecomment-1841700420 Going to fix the formatting issues soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to