chucheng92 commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1867156919
The commit name "Add DATE_SUB test and DATE_DIFF" but you actually add
DATE_ADD and DATE_DIFF. could you recheck it?
--
This is an automated message from the Apache Git Service.
To
chucheng92 commented on code in PR #3586:
URL: https://github.com/apache/calcite/pull/3586#discussion_r1433384145
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -11859,6 +11859,42 @@ void testTimestampDiff(boolean coercionEnabled) {
sonarcloud[bot] commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1866441880
## [), I will add it in the next pr. Because
date_sub does not have a
caicancai commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1865397151
> could you also check reference.md?
reference.md has the corresponding function description
--
This is an automated message from the Apache Git Service.
To respond to
chucheng92 commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1865396363
could you also check reference.md?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
caicancai commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1865358655
cc @chucheng92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sonarcloud[bot] commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1864561154
## [ {
caicancai commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1863778855
> Can u change your PR name to `Add DATE_SUB test and DATE_DIFF test on
SqlOperatorTest`? It is more recommended to use uppercase letters for function
names.
Ok，thank you
--
chucheng92 commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1863778061
Can u change your PR name to `Add DATE_SUB test and DATE_DIFF test on
SqlOperatorTest`, It is more recommended to use uppercase letters for function
names.
--
This is an automated
chucheng92 commented on code in PR #3586:
URL: https://github.com/apache/calcite/pull/3586#discussion_r1432198009
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -11920,6 +11957,24 @@ void testTimestampDiff(boolean coercionEnabled) {
sonarcloud[bot] commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1862897559
## [