libenchao closed pull request #3627: [CALCITE-6202] `sqlsh` does not print
error message when query fails
URL: https://github.com/apache/calcite/pull/3627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
libenchao commented on code in PR #3627:
URL: https://github.com/apache/calcite/pull/3627#discussion_r1452934528
##
plus/src/main/java/org/apache/calcite/adapter/os/SqlShell.java:
##
@@ -118,17 +118,18 @@ private static String model() {
/** Main entry point. */
JiajunBernoulli commented on code in PR #3627:
URL: https://github.com/apache/calcite/pull/3627#discussion_r1452218834
##
plus/src/main/java/org/apache/calcite/adapter/os/SqlShell.java:
##
@@ -118,17 +118,18 @@ private static String model() {
/** Main entry point. */
sonarcloud[bot] commented on PR #3627:
URL: https://github.com/apache/calcite/pull/3627#issuecomment-1891521286
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
libenchao commented on PR #3627:
URL: https://github.com/apache/calcite/pull/3627#issuecomment-1891486562
@mihaibudiu Thanks for the review, I have slightly changed the idea about
how to fix it, see more in the Jira comment of CALCITE-6202. And it seems not a
best practice to close the
sonarcloud[bot] commented on PR #3627:
URL: https://github.com/apache/calcite/pull/3627#issuecomment-1891319292
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
libenchao opened a new pull request, #3627:
URL: https://github.com/apache/calcite/pull/3627
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,