mihaibudiu merged PR #3785:
URL: https://github.com/apache/calcite/pull/3785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite
caicancai commented on PR #3785:
URL: https://github.com/apache/calcite/pull/3785#issuecomment-2141399389
@mihaibudiu @julianhyde @YiwenWu
Thanks for the review, squashed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1619142488
##
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##
@@ -421,9 +421,12 @@ public enum SqlKind {
/** {@code DECODE} function (Oracle). */
DECODE,
- /
sonarcloud[bot] commented on PR #3785:
URL: https://github.com/apache/calcite/pull/3785#issuecomment-2137464549
## [](https://sonarclo
YiwenWu commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1618723448
##
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##
@@ -421,9 +421,12 @@ public enum SqlKind {
/** {@code DECODE} function (Oracle). */
DECODE,
- /**
caicancai commented on PR #3785:
URL: https://github.com/apache/calcite/pull/3785#issuecomment-2136377502
@YiwenWu If you have time, can you help me take a look at this PR? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1603471671
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding -> o
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1603529235
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding -> o
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1603471671
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding -> o
mihaibudiu commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1600522936
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
caicancai commented on PR #3785:
URL: https://github.com/apache/calcite/pull/3785#issuecomment-2110531888
@mihaibudiu PATL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
sonarcloud[bot] commented on PR #3785:
URL: https://github.com/apache/calcite/pull/3785#issuecomment-2108615228
## [](https://sonarclo
caicancai commented on PR #3785:
URL: https://github.com/apache/calcite/pull/3785#issuecomment-2107959410
@mihaibudiu Hello, I opened jira to discuss the comparability of character
and boolean types because I'm not sure if this is a bug.
https://issues.apache.org/jira/browse/CALCITE-6409
13 matches
Mail list logo
