[GitHub] [calcite] sonarcloud[bot] commented on pull request #3394: [CALCITE-5914] Cache compiled regular expressions in SQL function runtime

sonarcloud[bot] commented on PR #3394: URL: https://github.com/apache/calcite/pull/3394#issuecomment-1694130697 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] julianhyde commented on a diff in pull request #3394: [CALCITE-5914] Cache compiled regular expressions in SQL function runtime

julianhyde commented on code in PR #3394: URL: https://github.com/apache/calcite/pull/3394#discussion_r1306169489 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -1195,6 +1220,10 @@ private static boolean allSame(List list) { return

[GitHub] [calcite] julianhyde commented on a diff in pull request #3394: [CALCITE-5914] Cache compiled regular expressions in SQL function runtime

julianhyde commented on code in PR #3394: URL: https://github.com/apache/calcite/pull/3394#discussion_r1306169201 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3160,97 +3293,176 @@ public static String timeWithLocalTimeZoneToString(int v, TimeZone

[GitHub] [calcite] julianhyde commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

julianhyde commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1306115154 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4792,6 +4828,35 @@ private void convertValuesImpl( true); } + private

[GitHub] [calcite] julianhyde commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

julianhyde commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1306111779 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4809,6 +4874,30 @@ private static class RegisterArgs { } } + /**

[GitHub] [calcite] julianhyde commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

julianhyde commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1306108747 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4792,6 +4828,35 @@ private void convertValuesImpl( true); } + private

[GitHub] [calcite] julianhyde commented on a diff in pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

julianhyde commented on code in PR #3393: URL: https://github.com/apache/calcite/pull/3393#discussion_r1306107876 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4769,21 +4779,47 @@ private void convertValuesImpl( return; } -for

[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1305968899 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1305965977 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3252: [CALCITE-5766] Add SAFE_NEGATE function (enabled for BigQuery library)

sonarcloud[bot] commented on PR #3252: URL: https://github.com/apache/calcite/pull/3252#issuecomment-1693588849 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] thomasrebele commented on a diff in pull request #3394: [CALCITE-5914] Cache compiled regular expressions in SQL function runtime

thomasrebele commented on code in PR #3394: URL: https://github.com/apache/calcite/pull/3394#discussion_r1305491467 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -1195,6 +1220,10 @@ private static boolean allSame(List list) { return

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

herunkang2018 commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1305571505 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -929,6 +929,29 @@ public static String charFromUtf8(int n) { return

[calcite] branch main updated: [CALCITE-5922] The SQL generated for the POSITION function(with 3 input arguments) by the SparkSqlDialect is not recognized by Spark SQL

This is an automated email from the ASF dual-hosted git repository. jiajunxie pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 730361b664 [CALCITE-5922] The SQL generated for

[GitHub] [calcite] JiajunBernoulli merged pull request #3363: [CALCITE-5922] The SQL generated for the POSITION function(with 3 input arguments) by the SparkSqlDialect is not recognized by Spark SQL

JiajunBernoulli merged PR #3363: URL: https://github.com/apache/calcite/pull/3363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] zabetak commented on pull request #3322: Remove mentions of binary distribution from README

zabetak commented on PR #3322: URL: https://github.com/apache/calcite/pull/3322#issuecomment-1693077500 Thanks for the review @chucheng92 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[calcite] 01/02: [CALCITE-5615] Run SQL Logic Test suite using Calcite's HSQLDB JDBC adapter

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 996692e36a0d1bdff2b3fd1e08fa99fcc755f2ab Author: Mihai Budiu AuthorDate: Tue Apr 11 16:44:36 2023 -0700

[calcite] 02/02: Remove mentions of binary distribution from README

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit d802314e69f1eb975558ad3fd6013dc05ddaef7a Author: Stamatis Zampetakis AuthorDate: Tue Jul 18 14:15:01 2023 +0300

[GitHub] [calcite] zabetak closed pull request #3322: Remove mentions of binary distribution from README

zabetak closed pull request #3322: Remove mentions of binary distribution from README URL: https://github.com/apache/calcite/pull/3322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[calcite] branch main updated (eff56f938c -> d802314e69)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from eff56f938c Update broken link in RelMetadataProvider Javadoc new 996692e36a [CALCITE-5615] Run SQL Logic Test

[GitHub] [calcite] zabetak closed pull request #3145: [CALCITE-5615] Program to run SQL Logic Tests for Calcite

zabetak closed pull request #3145: [CALCITE-5615] Program to run SQL Logic Tests for Calcite URL: https://github.com/apache/calcite/pull/3145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the