Re: [PR] [CALCITE-5825] Add URL_ENCODE and URL_DECODE function (enabled in Spark library) [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3318: URL: https://github.com/apache/calcite/pull/3318#issuecomment-1782325018 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-26 Thread via GitHub
caicancai commented on PR #3488: URL: https://github.com/apache/calcite/pull/3488#issuecomment-1782194355 cc @zabetak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3488: URL: https://github.com/apache/calcite/pull/3488#issuecomment-1782193228 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-26 Thread via GitHub
caicancai closed pull request #3488: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails URL: https://github.com/apache/calcite/pull/3488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-26 Thread via GitHub
caicancai opened a new pull request, #3488: URL: https://github.com/apache/calcite/pull/3488 fix #6075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]

2023-10-26 Thread via GitHub
libenchao commented on PR #3486: URL: https://github.com/apache/calcite/pull/3486#issuecomment-1782093532 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781828354 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[calcite-site] branch main updated: Website deployed from calcite@0f824ed0045f9594959d459776177bb5f46d7620

2023-10-26 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new fff66144f Website deployed from

[calcite] branch site updated: [MINOR] Add Mihai Budiu to contributors list

2023-10-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new a0181e81f8 [MINOR] Add Mihai Budiu to

[calcite] branch main updated: [MINOR] Add Mihai Budiu to contributors list

2023-10-26 Thread mbudiu
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 0f824ed004 [MINOR] Add Mihai Budiu to contributors

Re: [PR] [MINOR] Add Mihai Budiu to contributors list [calcite]

2023-10-26 Thread via GitHub
mihaibudiu merged PR #3487: URL: https://github.com/apache/calcite/pull/3487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [MINOR] Add Mihai Budiu to contributors list [calcite]

2023-10-26 Thread via GitHub
mihaibudiu opened a new pull request, #3487: URL: https://github.com/apache/calcite/pull/3487 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781787373 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5918] Add MAP function (enabled in Spark library) [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3459: URL: https://github.com/apache/calcite/pull/3459#issuecomment-1781758539 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781732860 I pushed a second commit re-enabling a few more tests. Now the PR is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781706791 Actually, I think I can cover a few more cases. Give me a bit more time to see if I can handle the string literal casts. -- This is an automated message from the Apache Git Service.

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781689711 I believe that this PR is ready for 1.36. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781688426 I have re-enabled a few tests that now pass, but not all, though a new commit. I won't assign CALCITE-2539 to myself, since it covers many other operations besides casts. I will

Re: [PR] [CALCITE-5918] Add MAP function (enabled in Spark library) [calcite]

2023-10-26 Thread via GitHub
chucheng92 commented on PR #3459: URL: https://github.com/apache/calcite/pull/3459#issuecomment-1781572743 thank you all for patient reviewing! all comments are resolved. ci passed. @tanclary could you help to merge it? so we can add it in up-coming 1.36. -- This is an automated

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781565813 That bug also covers casts from VARCHAR to various numeric types, which I also didn't address in this PR. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781559926 In this PR I have handled casts to values that are represented as Number in Java, but not DECIMAL. It looks like there are some bugs remaining there, including Bug.CALCITE_2539. I

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3439: URL: https://github.com/apache/calcite/pull/3439#issuecomment-1781518461 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5918] Add MAP function (enabled in Spark library) [calcite]

2023-10-26 Thread via GitHub
chucheng92 commented on PR #3459: URL: https://github.com/apache/calcite/pull/3459#issuecomment-1781498518 @tanclary Thanks for the reminder. I checked sonar report and problems are roughly divided into three categories: 1. Assignment of index i in for-loop 2. The MAP of

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

2023-10-26 Thread via GitHub
LakeShen commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1373433134 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -3817,6 +3817,29 @@ public static RelNode pushDownJoinConditions(Join originalJoin,

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

2023-10-26 Thread via GitHub
LakeShen commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1373424946 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -3817,6 +3817,29 @@ public static RelNode pushDownJoinConditions(Join originalJoin,

Re: [PR] [CALCITE-5826] Add FIND_IN_SET function (enabled in Hive and Spark library) [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3317: URL: https://github.com/apache/calcite/pull/3317#issuecomment-1781321965 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5826] Add FIND_IN_SET function (enabled in Hive and Spark library) [calcite]

2023-10-26 Thread via GitHub
herunkang2018 commented on code in PR #3317: URL: https://github.com/apache/calcite/pull/3317#discussion_r1373281355 ## site/_docs/reference.md: ## @@ -2729,6 +2729,7 @@ BigQuery's type system uses confusingly different names for types and functions: | o | EXTRACT(xml, xpath,

Re: [PR] [CALCITE-5826] Add FIND_IN_SET function (enabled in Hive and Spark library) [calcite]

2023-10-26 Thread via GitHub
herunkang2018 commented on code in PR #3317: URL: https://github.com/apache/calcite/pull/3317#discussion_r1372602405 ## site/_docs/reference.md: ## @@ -2729,6 +2729,7 @@ BigQuery's type system uses confusingly different names for types and functions: | o | EXTRACT(xml, xpath,

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

2023-10-26 Thread via GitHub
zabetak commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1373234881 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -3817,6 +3817,29 @@ public static RelNode pushDownJoinConditions(Join originalJoin,

Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3486: URL: https://github.com/apache/calcite/pull/3486#issuecomment-1781088395 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]

2023-10-26 Thread via GitHub
rubenada commented on PR #3486: URL: https://github.com/apache/calcite/pull/3486#issuecomment-1781047870 This PR supersedes https://github.com/apache/calcite/pull/3390 FYI @libenchao @arkanovicz -- This is an automated message from the Apache Git Service. To respond to the

[PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]

2023-10-26 Thread via GitHub
rubenada opened a new pull request, #3486: URL: https://github.com/apache/calcite/pull/3486 [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[calcite-site] branch main updated: Website deployed from calcite@8821eaf94b08dd5c55074b900201da7c386c1635

2023-10-26 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new aedd90777 Website deployed from

[calcite] branch site updated: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new 35104e0c1c [CALCITE-6075] Site: Cloning source

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
zabetak closed pull request #3485: [CALCITE-6075] The git link to download the source code is incorrect URL: https://github.com/apache/calcite/pull/3485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[calcite] branch main updated: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 8821eaf94b [CALCITE-6075] Site: Cloning source

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
chucheng92 commented on PR #3485: URL: https://github.com/apache/calcite/pull/3485#issuecomment-1780823571 > Actually the `git://` URL is not invalid it just points to the use of the git protocol and I believe this used to work in the past. Any idea on why it is not working at the moment?

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-26 Thread via GitHub
zabetak commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1372866281 ## site/_docs/algebra.md: ## @@ -309,10 +309,6 @@ LogicalRepeatUnion(all=[true]) LogicalTableScan(table=[[aux]]) {% endhighlight %} -Note that there is no

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
caicancai commented on PR #3485: URL: https://github.com/apache/calcite/pull/3485#issuecomment-1780778964 @chucheng92 Hello, there seems to be some errors in the cli at present, but I have not changed the code in it. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
chucheng92 commented on PR #3485: URL: https://github.com/apache/calcite/pull/3485#issuecomment-1780754565 > cc @chucheng92 , I just changed it directly in the makerdown file on github, but it was difficult to change it to the commit name. I'm sorry for this. you can use 'git commit

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
caicancai commented on PR #3485: URL: https://github.com/apache/calcite/pull/3485#issuecomment-1780747465 cc @chucheng92 , I just changed it directly in the makerdown file on github, but it was difficult to change it to the commit name. I'm sorry for this. -- This is an automated message

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
sonarcloud[bot] commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780737442 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
caicancai commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780710186 ok , let me try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
chucheng92 commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780705060 @caicancai no need to close this PR. just change your local commit name and re-push it. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
caicancai commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780702036 > could you change the commit name ? ok, I’ll submit a PR again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
caicancai closed pull request #3484: [CALCITE-6075] The git link to download the source code is incorrect URL: https://github.com/apache/calcite/pull/3484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]

2023-10-26 Thread via GitHub
chucheng92 commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780696984 NIT: could you change the commit name ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-26 Thread via GitHub
rubenada commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1780586778 Thanks for moving this forward @mihaibudiu . PR looks already in a good shape, I'm sure it will make it into 1.36. I just realized, there's another ticket which might be potentially

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-26 Thread via GitHub
rubenada commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1372704477 ## core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties: ## @@ -63,6 +63,8 @@ IncompatibleValueType=Values passed to {0} operator must have

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-26 Thread via GitHub
rubenada commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1372703471 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -5232,6 +5232,39 @@ void testReturnsCorrectRowTypeOnCombinedJoin() { + "select *