(calcite) branch main updated: [CALCITE-6202] `sqlsh` does not print error message when query fails

2024-01-15 Thread libenchao
This is an automated email from the ASF dual-hosted git repository. libenchao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 86d5720c7f [CALCITE-6202] `sqlsh` does not

Re: [PR] [CALCITE-6202] `sqlsh` does not print error message when query fails [calcite]

2024-01-15 Thread via GitHub
libenchao closed pull request #3627: [CALCITE-6202] `sqlsh` does not print error message when query fails URL: https://github.com/apache/calcite/pull/3627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CALCITE-6202] `sqlsh` does not print error message when query fails [calcite]

2024-01-15 Thread via GitHub
libenchao commented on code in PR #3627: URL: https://github.com/apache/calcite/pull/3627#discussion_r1452934528 ## plus/src/main/java/org/apache/calcite/adapter/os/SqlShell.java: ## @@ -118,17 +118,18 @@ private static String model() { /** Main entry point. */

Re: [PR] [CALCITE-6162] Add rule(s) to remove joins with constant single tuple… [calcite]

2024-01-15 Thread via GitHub
HanumathRao commented on PR #3597: URL: https://github.com/apache/calcite/pull/3597#issuecomment-1893066965 > I have approved, but I still made a few small suggestions. It looks like the CI is unhappy. Thanks. I am not sure why only PR runs are showing this issue. The tests executed

Re: [PR] [CALCITE-6162] Add rule(s) to remove joins with constant single tuple… [calcite]

2024-01-15 Thread via GitHub
sonarcloud[bot] commented on PR #3597: URL: https://github.com/apache/calcite/pull/3597#issuecomment-1893065574 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

(calcite) branch main updated (e71d59fe92 -> 24ea6bef75)

2024-01-15 Thread mbudiu
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from e71d59fe92 [CALCITE-6097] Gridism CSS dependency is mispelled in LICENSE add 24ea6bef75 [CALCITE-6200] RelJson

Re: [PR] [CALCITE-6200] RelJson throw UnsupportedOperationException for RexDyn… [calcite]

2024-01-15 Thread via GitHub
mihaibudiu merged PR #3626: URL: https://github.com/apache/calcite/pull/3626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6200] RelJson throw UnsupportedOperationException for RexDyn… [calcite]

2024-01-15 Thread via GitHub
JiajunBernoulli commented on code in PR #3626: URL: https://github.com/apache/calcite/pull/3626#discussion_r1452858824 ## core/src/test/java/org/apache/calcite/plan/RelWriterTest.java: ## @@ -442,6 +443,32 @@ class RelWriterTest { + " ]\n" + "}"; + public

Re: [PR] [CALCITE-6200] RelJson throw UnsupportedOperationException for RexDyn… [calcite]

2024-01-15 Thread via GitHub
sonarcloud[bot] commented on PR #3626: URL: https://github.com/apache/calcite/pull/3626#issuecomment-1892969818 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-3679] Allow lambda expressions in SQL queries [calcite]

2024-01-15 Thread via GitHub
mihaibudiu closed pull request #1733: [CALCITE-3679] Allow lambda expressions in SQL queries URL: https://github.com/apache/calcite/pull/1733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [CALCITE-3679] Allow lambda expressions in SQL queries [calcite]

2024-01-15 Thread via GitHub
mihaibudiu commented on PR #1733: URL: https://github.com/apache/calcite/pull/1733#issuecomment-1892918479 Closing in favor of #3502. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [CALCITE-3679] Allow lambda expressions in SQL queries [calcite]

2024-01-15 Thread via GitHub
MasseGuillaume commented on PR #1733: URL: https://github.com/apache/calcite/pull/1733#issuecomment-1892914119 @mihaibudiu can you close this PR? CALCITE-3679 got resolved in https://github.com/apache/calcite/pull/3502 -- This is an automated message from the Apache Git Service. To

Re: [PR] [CALCITE-6162] Add rule(s) to remove joins with constant single tuple… [calcite]

2024-01-15 Thread via GitHub
mihaibudiu commented on PR #3597: URL: https://github.com/apache/calcite/pull/3597#issuecomment-1892660142 I have approved, but I still made a few small suggestions. It looks like the CI is unhappy. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CALCITE-6162] Add rule(s) to remove joins with constant single tuple… [calcite]

2024-01-15 Thread via GitHub
mihaibudiu commented on code in PR #3597: URL: https://github.com/apache/calcite/pull/3597#discussion_r1452675906 ## core/src/main/java/org/apache/calcite/rel/rules/SingleValuesOptimizationRules.java: ## @@ -0,0 +1,374 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [CALCITE-6200] RelJson throw UnsupportedOperationException for RexDyn… [calcite]

2024-01-15 Thread via GitHub
mihaibudiu commented on code in PR #3626: URL: https://github.com/apache/calcite/pull/3626#discussion_r1452671962 ## core/src/test/java/org/apache/calcite/plan/RelWriterTest.java: ## @@ -442,6 +443,32 @@ class RelWriterTest { + " ]\n" + "}"; + public static

(calcite) branch main updated (b2be7e1dac -> e71d59fe92)

2024-01-15 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from b2be7e1dac [CALCITE-6044] RelMetadataQuery should regard single-row relational expressions as unique new

(calcite) 01/02: [CALCITE-6096] Remove obsolete html5shiv and respond entries from LICENSE

2024-01-15 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 402740d970e162dd0a83172d509199c02a2a23a3 Author: Stamatis Zampetakis AuthorDate: Wed Nov 8 12:30:14 2023 +0100

(calcite) 02/02: [CALCITE-6097] Gridism CSS dependency is mispelled in LICENSE

2024-01-15 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit e71d59fe92c5b39293830ed3416a4db8ac8a369a Author: Stamatis Zampetakis AuthorDate: Wed Nov 8 13:22:24 2023 +0100

Re: [PR] [CALCITE-6096] Remove obsolete html5shiv and respond entries from LICENSE [calcite]

2024-01-15 Thread via GitHub
zabetak closed pull request #3508: [CALCITE-6096] Remove obsolete html5shiv and respond entries from LICENSE URL: https://github.com/apache/calcite/pull/3508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [CALCITE-6097] Gridism CSS dependency is mispelled in LICENSE [calcite]

2024-01-15 Thread via GitHub
zabetak closed pull request #3509: [CALCITE-6097] Gridism CSS dependency is mispelled in LICENSE URL: https://github.com/apache/calcite/pull/3509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [CALCITE-6202] `sqlsh` does not print error message when query fails [calcite]

2024-01-15 Thread via GitHub
JiajunBernoulli commented on code in PR #3627: URL: https://github.com/apache/calcite/pull/3627#discussion_r1452218834 ## plus/src/main/java/org/apache/calcite/adapter/os/SqlShell.java: ## @@ -118,17 +118,18 @@ private static String model() { /** Main entry point. */

Re: [PR] [CALCITE-6202] `sqlsh` does not print error message when query fails [calcite]

2024-01-15 Thread via GitHub
sonarcloud[bot] commented on PR #3627: URL: https://github.com/apache/calcite/pull/3627#issuecomment-1891521286 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate