Re: [PR] [CALCITE-6172] PoC for parameterized tests [calcite]

2024-01-22 Thread via GitHub
snuyanzin closed pull request #3590: [CALCITE-6172] PoC for parameterized tests URL: https://github.com/apache/calcite/pull/3590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [CALCITE-6172] PoC for parameterized tests [calcite]

2024-01-22 Thread via GitHub
snuyanzin commented on PR #3590: URL: https://github.com/apache/calcite/pull/3590#issuecomment-1905433095 closing since the PR was merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [CALCITE-6171] Support Gremlin Adapter [calcite]

2024-01-22 Thread via GitHub
kaori-seasons commented on code in PR #3606: URL: https://github.com/apache/calcite/pull/3606#discussion_r1462797799 ## settings.gradle.kts: ## @@ -64,6 +64,7 @@ include( "cassandra", "core", "druid", +"gremlin", Review Comment: solved -- This is an

Re: [PR] [CALCITE-6171] Support Gremlin Adapter [calcite]

2024-01-22 Thread via GitHub
kaori-seasons commented on PR #3606: URL: https://github.com/apache/calcite/pull/3606#issuecomment-1905371932 > @kaori-seasons Thank you for writing so much code. > > Please fix CI and add document in site like

Re: [PR] CALCITE-6208 update JSON_VALUE return type inference to make explicit array return types be nullable with nullable elements [calcite]

2024-01-22 Thread via GitHub
clintropolis commented on code in PR #3633: URL: https://github.com/apache/calcite/pull/3633#discussion_r1462746522 ## core/src/main/java/org/apache/calcite/sql/fun/SqlJsonValueFunction.java: ## @@ -54,20 +53,33 @@ public class SqlJsonValueFunction extends SqlFunction {

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
sonarcloud[bot] commented on PR #3642: URL: https://github.com/apache/calcite/pull/3642#issuecomment-1905306950 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
caicancai closed pull request #3642: [CALCITE-6215] Support century format datetime/timestamp in pg URL: https://github.com/apache/calcite/pull/3642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
chucheng92 commented on code in PR #3642: URL: https://github.com/apache/calcite/pull/3642#discussion_r1462675662 ## site/_docs/reference.md: ## @@ -2859,7 +2859,7 @@ In the following: | b | TIME_DIFF(time, time2, timeUnit) | Returns the whole number of

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
chucheng92 commented on code in PR #3642: URL: https://github.com/apache/calcite/pull/3642#discussion_r1462675662 ## site/_docs/reference.md: ## @@ -2859,7 +2859,7 @@ In the following: | b | TIME_DIFF(time, time2, timeUnit) | Returns the whole number of

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
chucheng92 commented on code in PR #3642: URL: https://github.com/apache/calcite/pull/3642#discussion_r1462668798 ## site/_docs/reference.md: ## @@ -2859,7 +2859,7 @@ In the following: | b | TIME_DIFF(time, time2, timeUnit) | Returns the whole number of

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
caicancai commented on code in PR #3642: URL: https://github.com/apache/calcite/pull/3642#discussion_r1462672738 ## site/_docs/reference.md: ## @@ -2859,7 +2859,7 @@ In the following: | b | TIME_DIFF(time, time2, timeUnit) | Returns the whole number of

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
chucheng92 commented on code in PR #3642: URL: https://github.com/apache/calcite/pull/3642#discussion_r1462668798 ## site/_docs/reference.md: ## @@ -2859,7 +2859,7 @@ In the following: | b | TIME_DIFF(time, time2, timeUnit) | Returns the whole number of

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
chucheng92 commented on code in PR #3642: URL: https://github.com/apache/calcite/pull/3642#discussion_r1462668798 ## site/_docs/reference.md: ## @@ -2859,7 +2859,7 @@ In the following: | b | TIME_DIFF(time, time2, timeUnit) | Returns the whole number of

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

2024-01-22 Thread via GitHub
chucheng92 commented on code in PR #3643: URL: https://github.com/apache/calcite/pull/3643#discussion_r1462649966 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -5204,7 +5204,11 @@ public static List compact(List list) { public static List

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

2024-01-22 Thread via GitHub
caicancai commented on code in PR #3643: URL: https://github.com/apache/calcite/pull/3643#discussion_r1462644749 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -5204,7 +5204,11 @@ public static List compact(List list) { public static List

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
sonarcloud[bot] commented on PR #3642: URL: https://github.com/apache/calcite/pull/3642#issuecomment-1905164588 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

2024-01-22 Thread via GitHub
mihaibudiu commented on code in PR #3643: URL: https://github.com/apache/calcite/pull/3643#discussion_r1462365228 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -5204,7 +5204,11 @@ public static List compact(List list) { public static List

Re: [PR] [CALCITE-6215] Support century format datetime/timestamp in pg [calcite]

2024-01-22 Thread via GitHub
mihaibudiu commented on code in PR #3642: URL: https://github.com/apache/calcite/pull/3642#discussion_r1462212376 ## babel/src/test/resources/sql/postgresql.iq: ## @@ -63,6 +63,11 @@ EXPR$0 2022-06-03 12:15:48.678 !ok Review Comment: Yes. That file has grown very large,

Re: [PR] [CALCITE-6205] Add BITAND_AGG, BITOR_AGG functions (enabled in Snowfl… [calcite]

2024-01-22 Thread via GitHub
tanclary commented on PR #3630: URL: https://github.com/apache/calcite/pull/3630#issuecomment-1904373260 Are there any other comments @JiajunBernoulli @olivrlee @mihaibudiu ? If not, I will probably merge this within the next day or so. -- This is an automated message from the Apache Git

(calcite) branch main updated: [CALCITE-6189] Improve FormatElementEnumTest

2024-01-22 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 4d8d6047f1 [CALCITE-6189] Improve

Re: [PR] [CALCITE-6189] Improve FormatElementEnumTest [calcite]

2024-01-22 Thread via GitHub
tanclary merged PR #3609: URL: https://github.com/apache/calcite/pull/3609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

2024-01-22 Thread via GitHub
caicancai commented on PR #3643: URL: https://github.com/apache/calcite/pull/3643#issuecomment-1904256700 @chucheng92 Hello, I'm not done yet, I want to make sure the way I'm fixing it is acceptable -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] [CALCITE-6209] Long queries are failing with "java.net.SocketTimeoutE… [calcite-avatica]

2024-01-22 Thread via GitHub
stoty opened a new pull request, #236: URL: https://github.com/apache/calcite-avatica/pull/236 …xception: Read timed out" after 3 minutes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(calcite-site) branch main updated: Website deployed from calcite@d260a7dd6db541191e84c38135d2d436510dfa08

2024-01-22 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new 1aae9ec2e Website deployed from

(calcite) branch site updated: Site: Remove committer by request process

2024-01-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new 7056273556 Site: Remove committer by request

(calcite) branch main updated (e2c84a6485 -> d260a7dd6d)

2024-01-22 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from e2c84a6485 [CALCITE-6111] Explicit cast from expression to numeric type doesn't check overflow new 58edb0e85f

Re: [PR] [CALCITE-6098] Update LICENSE and NOTICE for Jekyll website template [calcite]

2024-01-22 Thread via GitHub
zabetak closed pull request #3510: [CALCITE-6098] Update LICENSE and NOTICE for Jekyll website template URL: https://github.com/apache/calcite/pull/3510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(calcite) 01/02: [CALCITE-6098] Update LICENSE and NOTICE for Jekyll website template

2024-01-22 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit 58edb0e85f01580961f9fb07f171686166a0da34 Author: Stamatis Zampetakis AuthorDate: Wed Nov 8 14:32:28 2023 +0100

(calcite) 02/02: Site: Remove committer by request process

2024-01-22 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit d260a7dd6db541191e84c38135d2d436510dfa08 Author: Stamatis Zampetakis AuthorDate: Fri Jan 12 11:18:41 2024 +0100

Re: [PR] Site: Remove committer by request process [calcite]

2024-01-22 Thread via GitHub
zabetak closed pull request #3638: Site: Remove committer by request process URL: https://github.com/apache/calcite/pull/3638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [CALCITE-6189] Improve FormatElementEnumTest [calcite]

2024-01-22 Thread via GitHub
caicancai commented on code in PR #3609: URL: https://github.com/apache/calcite/pull/3609#discussion_r1461581817 ## core/src/test/java/org/apache/calcite/util/format/FormatElementEnumTest.java: ## @@ -28,150 +28,94 @@ * Unit test for {@link FormatElementEnum}. */ class

Re: [PR] [CALCITE-6189] Improve FormatElementEnumTest [calcite]

2024-01-22 Thread via GitHub
caicancai commented on code in PR #3609: URL: https://github.com/apache/calcite/pull/3609#discussion_r1461581033 ## core/src/test/java/org/apache/calcite/util/format/FormatElementEnumTest.java: ## @@ -28,150 +28,94 @@ * Unit test for {@link FormatElementEnum}. */ class

Re: [PR] [CALCITE-6189] Improve FormatElementEnumTest [calcite]

2024-01-22 Thread via GitHub
caicancai commented on PR #3609: URL: https://github.com/apache/calcite/pull/3609#issuecomment-1903456672 @XuQianJin-Stars Good to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the