sonarcloud[bot] commented on PR #3768:
URL: https://github.com/apache/calcite/pull/3768#issuecomment-2078673510
## [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2078316741
## [
to 3e9e9295d3
Author: snuyanzin
Date: Thu Apr 25 20:01:33 2024
New Revision: 68794
Log:
Uploading release candidate Apache Calcite calcite-1.37.0-rc2 to dev area
Added:
dev/calcite/apache-calcite-1.37.0-rc2/
dev/calcite/apache-calcite-1.37.0-rc2/apache-calcite-1.37.0-src.tar.gz
This is an automated email from the ASF dual-hosted git repository.
snuyanzin pushed a change to annotated tag calcite-1.37.0-rc2
in repository https://gitbox.apache.org/repos/asf/calcite.git
*** WARNING: tag calcite-1.37.0-rc2 was deleted! ***
tag was e6f6b00628
The revisions that were
mihaibudiu commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1580018917
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
mihaibudiu commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2078003367
The amount of testing is very impressive. These won't be easy to review. I
assume they were checked against postgres.
You should address the failures reported by the CI.
--
This
mihaibudiu commented on code in PR #3771:
URL: https://github.com/apache/calcite/pull/3771#discussion_r1580009150
##
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##
@@ -8056,6 +8056,17 @@ private void checkGetTimestamp(Connection con) throws
SQLException {
mihaibudiu commented on PR #3771:
URL: https://github.com/apache/calcite/pull/3771#issuecomment-2077972107
When you respond to comments you should not force-push, but rather add new
commits, to make it easier to review what's new.
--
This is an automated message from the Apache Git
normanj-bitquill commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-207870
Need to properly separate the MySQL/Oracle implementation of `TO_CHAR` from
the PostgreSQL implementation.
--
This is an automated message from the Apache Git Service.
To
Author: snuyanzin
Date: Thu Apr 25 16:42:04 2024
New Revision: 68793
Log:
Wrong branch while rc creation
Removed:
dev/calcite/apache-calcite-1.37.0-rc2/
This is an automated email from the ASF dual-hosted git repository.
snuyanzin pushed a change to annotated tag calcite-1.37.0-rc2
in repository https://gitbox.apache.org/repos/asf/calcite.git
*** WARNING: tag calcite-1.37.0-rc2 was modified! ***
from aa8d81bf1f (commit)
to e6f6b00628
Author: snuyanzin
Date: Thu Apr 25 16:39:24 2024
New Revision: 68792
Log:
Uploading release candidate Apache Calcite calcite-1.37.0-rc2 to dev area
Added:
dev/calcite/apache-calcite-1.37.0-rc2/
dev/calcite/apache-calcite-1.37.0-rc2/apache-calcite-1.37.0-src.tar.gz
Author: snuyanzin
Date: Thu Apr 25 16:34:20 2024
New Revision: 68791
Log:
Need another rc for Apache Calcite 1.37.0
Removed:
dev/calcite/apache-calcite-1.37.0-rc0/
caicancai commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1579547887
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
caicancai commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1579578732
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
caicancai commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1579547887
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
caicancai commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1579547887
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
caicancai commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1579514354
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
caicancai commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1579514354
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
zabetak merged PR #3770:
URL: https://github.com/apache/calcite/pull/3770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new aa8d81bf1f [CALCITE-6384] Add ASF header to
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new f78dd940d7 [CALCITE-6385] LintTest fails when run
zabetak merged PR #3772:
URL: https://github.com/apache/calcite/pull/3772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
snuyanzin commented on PR #3772:
URL: https://github.com/apache/calcite/pull/3772#issuecomment-2077078136
@zabetak thanks a lot for working on it
yep, it would be great if you merge it and then I will create another RC
--
This is an automated message from the Apache Git Service.
To
snuyanzin commented on PR #3770:
URL: https://github.com/apache/calcite/pull/3770#issuecomment-2077075197
@zabetak yep agree, I think it would be a good idea to merge it before
another RC
thanks for working on it!
--
This is an automated message from the Apache Git Service.
To respond
dawidwys commented on PR #3771:
URL: https://github.com/apache/calcite/pull/3771#issuecomment-2077041983
@mihaibudiu I extended the PR with runtime evaluation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
caicancai commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1579315119
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
zabetak commented on PR #3770:
URL: https://github.com/apache/calcite/pull/3770#issuecomment-2076968123
@snuyanzin Since we are cutting another RC let me know if you want me to
merge this to main or do it after.
--
This is an automated message from the Apache Git Service.
To respond to
caicancai commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1579315119
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding
zabetak commented on PR #3772:
URL: https://github.com/apache/calcite/pull/3772#issuecomment-2076966456
Thanks for the review @rubenada !
@snuyanzin I know that `main` is on code freeze so let me know if I can
merge this or you have another workflow in mind.
--
This is an
zabetak commented on PR #3772:
URL: https://github.com/apache/calcite/pull/3772#issuecomment-2076909217
I run the tests through IntelliJ, git repo, and source, and it works
everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sonarcloud[bot] commented on PR #3772:
URL: https://github.com/apache/calcite/pull/3772#issuecomment-2076900077
## [