[GitHub] [calcite] olivrlee commented on a diff in pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-17 Thread via GitHub
olivrlee commented on code in PR #3093: URL: https://github.com/apache/calcite/pull/3093#discussion_r1140678532 ## babel/src/test/resources/sql/big-query.iq: ## Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] olivrlee commented on a diff in pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-14 Thread via GitHub
olivrlee commented on code in PR #3093: URL: https://github.com/apache/calcite/pull/3093#discussion_r1136198429 ## core/src/main/java/org/apache/calcite/sql/SqlKind.java: ## @@ -639,6 +639,10 @@ public enum SqlKind { */ CAST, + /** + * The {@code SAFE_CAST}

[GitHub] [calcite] olivrlee commented on a diff in pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-13 Thread via GitHub
olivrlee commented on code in PR #3093: URL: https://github.com/apache/calcite/pull/3093#discussion_r1134601302 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java: ## @@ -1198,6 +1200,26 @@ public static > FunctionExpression lambda( return

[GitHub] [calcite] olivrlee commented on a diff in pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-13 Thread via GitHub
olivrlee commented on code in PR #3093: URL: https://github.com/apache/calcite/pull/3093#discussion_r1133012102 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java: ## @@ -1198,6 +1200,26 @@ public static > FunctionExpression lambda( return

[GitHub] [calcite] olivrlee commented on a diff in pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-13 Thread via GitHub
olivrlee commented on code in PR #3093: URL: https://github.com/apache/calcite/pull/3093#discussion_r1133012102 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java: ## @@ -1198,6 +1200,26 @@ public static > FunctionExpression lambda( return

[GitHub] [calcite] olivrlee commented on a diff in pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-10 Thread via GitHub
olivrlee commented on code in PR #3093: URL: https://github.com/apache/calcite/pull/3093#discussion_r1133012102 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java: ## @@ -1198,6 +1200,26 @@ public static > FunctionExpression lambda( return

[GitHub] [calcite] olivrlee commented on a diff in pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-10 Thread via GitHub
olivrlee commented on code in PR #3093: URL: https://github.com/apache/calcite/pull/3093#discussion_r1132905701 ## core/src/main/java/org/apache/calcite/rex/RexExecutable.java: ## @@ -102,6 +102,38 @@ public void reduce(RexBuilder rexBuilder, List constExps,