[GitHub] [calcite] olivrlee commented on pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-22 Thread via GitHub
olivrlee commented on PR #3093: URL: https://github.com/apache/calcite/pull/3093#issuecomment-1480037625 I did take a look but communicated to Julian offline* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] olivrlee commented on pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-14 Thread via GitHub
olivrlee commented on PR #3093: URL: https://github.com/apache/calcite/pull/3093#issuecomment-1468970159 I'm still in the middle of cleaning up the PR, thanks for reviewing @zoudan Do you have any thoughts on SqlSyntax.SPECIAL? It *should* be SPECIAL, but the operator table

[GitHub] [calcite] olivrlee commented on pull request #3093: SAFE_CAST (enabled for BigQuery)

2023-03-10 Thread via GitHub
olivrlee commented on PR #3093: URL: https://github.com/apache/calcite/pull/3093#issuecomment-1464797100 Hey @julianhyde if you could take a look at what I've done here: