[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-15 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1353648387 Yeah in the mean time we have upgraded: upgrade opentelemetry to the version 1.21.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-15 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1353518319 Thanks for looking into this. Yeah I only tried with JDK11, as I use that primary due to Camel v3 is still Java 11 based. Could be that the JDK ForJoin pool behaves differently or

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-15 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1352773964 It happens when its the JDK fork-join pool that are in use ``` pool-17-thread-4 -> Valid context: false pool-17-thread-8 -> Valid context: false pool-17-thread-2 -> Valid

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-15 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1352760926 @lmolkova okay so there is a simple test error in core/camel-management And then there is a test error in your new test class (need to rename the class)

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-15 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1352760011 The test class needs to be renamed, CurrentSpanTests -> CurrentSpanTest Then when you run tests it will fail (also by CI as it was not run before) [ERROR] Errors:

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-15 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1352742101 [ERROR] Failures: [ERROR] org.apache.camel.management.RemoveEventNotifierTest.testRemove [ERROR] Run 1: RemoveEventNotifierTest.testRemove:79 expected: <17> but was: <20>

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-14 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1350795602 @lmolkova are you able to work on the test fixes as we would like to build the 3.20 release later this week -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-14 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1350668572 also run component/camel-spring-xml as it has a bunch of tests and some about event notifier -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-13 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1348975624 @lmolkova have you tested your latest code with the AWS servicebus to see if the diagram/span looks correct -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [camel] davsclaus commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-12 Thread GitBox
davsclaus commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1346261138 Using the event notifier to emit a "async processing" event is tricky as there are potentially more places this can happens in the core routing engine. However they all bubble up to the