[GitHub] [camel] lmolkova commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-16 Thread GitBox
lmolkova commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1355235300 Thank you all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [camel] lmolkova commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-15 Thread GitBox
lmolkova commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1353840089 @bvahdat sure, I rebased! I believe (again) that I fixed tests. There were two issues: 1. We still need to clean the context in `SendProcessor`: since we have multiple nested

[GitHub] [camel] lmolkova commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-15 Thread GitBox
lmolkova commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1353501033 thanks a lot, @davsclaus ! I was able to reproduce `testContextDoesNotLeak` locally with Java 11 (does not repro with 17 I used before) and working on fixing it. I'll try my best to

[GitHub] [camel] lmolkova commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-14 Thread GitBox
lmolkova commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1352139062 I believe I fixed broken tests, I have some unrelated local failures, but they are not related to my changes. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [camel] lmolkova commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-14 Thread GitBox
lmolkova commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1351859734 @bvahdat thanks! @davsclaus working on it and should will be able to fix all failures ASAP. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [camel] lmolkova commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-13 Thread GitBox
lmolkova commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1349670448 I can't repro build error locally and would appreciate if someone can post log from the pipeline run. Thanks! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [camel] lmolkova commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-13 Thread GitBox
lmolkova commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1349181738 @davsclaus, yes, I did (with Azure ServiceBus ) and yes, it works fine and looks the same as in the description. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [camel] lmolkova commented on pull request #8713: CAMEL-18661: Make span current and clear scope properly for async processing

2022-12-12 Thread GitBox
lmolkova commented on PR #8713: URL: https://github.com/apache/camel/pull/8713#issuecomment-1347197269 @bvahdat thank you! it should be fixed now. @davsclaus I removed notifications from everywhere except `CamelInternalProcessor` and yes, everything seems to be working. Do