[GitHub] [camel-k] tadayosi commented on pull request #3901: fix(#3896): Fix dependency inspector supporting property placeholders

2022-12-15 Thread GitBox
tadayosi commented on PR #3901: URL: https://github.com/apache/camel-k/pull/3901#issuecomment-1354310169 > I wonder if throwing an error at this state when the uri does not resolve to a component in the Catalog is the right thing to do in general. Using placeholders in the uri may be only

[GitHub] [camel-k] tadayosi commented on pull request #3901: fix(#3896): Fix dependency inspector supporting property placeholders

2022-12-15 Thread GitBox
tadayosi commented on PR #3901: URL: https://github.com/apache/camel-k/pull/3901#issuecomment-1354299231 > What about uri that for some other reason does not resolve to a component that we know. We also support jitpack dependencies and custom Maven repositories that might ship libraries

[GitHub] [camel-k] tadayosi commented on pull request #3901: fix(#3896): Fix dependency inspector supporting property placeholders

2022-12-14 Thread GitBox
tadayosi commented on PR #3901: URL: https://github.com/apache/camel-k/pull/3901#issuecomment-1352516553 Thinking a bit further, what should we really do with the use of Kamelet placeholders in terms of the dependency resolution? The original intention why we've added a stricter component

[GitHub] [camel-k] tadayosi commented on pull request #3901: fix(#3896): Fix dependency inspector supporting property placeholders

2022-12-14 Thread GitBox
tadayosi commented on PR #3901: URL: https://github.com/apache/camel-k/pull/3901#issuecomment-1352510771 Thanks a lot Christoph for taking care of this issue! As already commented in the review, I don't think checking only `:` in uri can cover all edge cases. For example: