[GitHub] [camel-karavan] f-ambroz commented on pull request #830: Refactoring of Karavan Core

2023-07-26 Thread via GitHub
f-ambroz commented on PR #830: URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1652956645 > @f-ambroz thanks! Could you please fix tests in karavan-core (just simple sort yaml results) and vscode build ? Will do! -- This is an automated message from the Apache Gi

[GitHub] [camel-karavan] f-ambroz commented on pull request #830: Refactoring of Karavan Core

2023-07-28 Thread via GitHub
f-ambroz commented on PR #830: URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1655337710 @mgubaidullin Tests are fixed. So the build should work now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [camel-karavan] f-ambroz commented on pull request #830: Refactoring of Karavan Core

2023-07-31 Thread via GitHub
f-ambroz commented on PR #830: URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1657818023 @mgubaidullin everything seems to be fixed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [camel-karavan] f-ambroz commented on pull request #830: Refactoring of Karavan Core

2023-07-31 Thread via GitHub
f-ambroz commented on PR #830: URL: https://github.com/apache/camel-karavan/pull/830#issuecomment-1659660944 > @f-ambroz is it OK that karavan-app is still `"target": "es5"` while core, designer are `"target": "es2022"` ? That is a good question that I do not have the answer for. 😄