[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #5184: Expand Splunk test coverage

2023-08-15 Thread via GitHub
JiriOndrusek commented on code in PR #5184: URL: https://github.com/apache/camel-quarkus/pull/5184#discussion_r1294326477 ## integration-tests/splunk/src/test/java/org/apache/camel/quarkus/component/splunk/it/SplunkTest.java: ## @@ -16,138 +16,153 @@ */ package org.apache.cam

[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #5184: Expand Splunk test coverage

2023-08-15 Thread via GitHub
JiriOndrusek commented on code in PR #5184: URL: https://github.com/apache/camel-quarkus/pull/5184#discussion_r1294326267 ## extensions/splunk/deployment/src/main/java/org/apache/camel/quarkus/component/splunk/deployment/SplunkProcessor.java: ## @@ -67,9 +67,10 @@ ReflectiveClas

[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #5184: Expand Splunk test coverage

2023-08-15 Thread via GitHub
JiriOndrusek commented on code in PR #5184: URL: https://github.com/apache/camel-quarkus/pull/5184#discussion_r1294304159 ## integration-tests/splunk/src/test/java/org/apache/camel/quarkus/component/splunk/it/SplunkTest.java: ## @@ -16,138 +16,153 @@ */ package org.apache.cam

[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #5184: Expand Splunk test coverage

2023-08-15 Thread via GitHub
JiriOndrusek commented on code in PR #5184: URL: https://github.com/apache/camel-quarkus/pull/5184#discussion_r1294304159 ## integration-tests/splunk/src/test/java/org/apache/camel/quarkus/component/splunk/it/SplunkTest.java: ## @@ -16,138 +16,153 @@ */ package org.apache.cam

[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #5184: Expand Splunk test coverage

2023-08-15 Thread via GitHub
JiriOndrusek commented on code in PR #5184: URL: https://github.com/apache/camel-quarkus/pull/5184#discussion_r1294304159 ## integration-tests/splunk/src/test/java/org/apache/camel/quarkus/component/splunk/it/SplunkTest.java: ## @@ -16,138 +16,153 @@ */ package org.apache.cam

[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #5184: Expand Splunk test coverage

2023-08-15 Thread via GitHub
JiriOndrusek commented on code in PR #5184: URL: https://github.com/apache/camel-quarkus/pull/5184#discussion_r1294289707 ## integration-tests/splunk/src/main/java/org/apache/camel/quarkus/component/splunk/it/SplunkResource.java: ## @@ -47,10 +46,10 @@ @ApplicationScoped publi

[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #5184: Expand Splunk test coverage

2023-08-15 Thread via GitHub
JiriOndrusek commented on code in PR #5184: URL: https://github.com/apache/camel-quarkus/pull/5184#discussion_r1294289241 ## integration-tests/splunk/README.adoc: ## @@ -0,0 +1,3 @@ +Splunk UI is helpful for testing. Review Comment: I was probably a little bit plain about it