jamesnetherton commented on a change in pull request #2751:
URL: https://github.com/apache/camel-quarkus/pull/2751#discussion_r648017410



##########
File path: 
integration-tests/jta/src/test/java/org/apache/camel/quarkus/component/jta/it/ActiveMQXATestResource.java
##########
@@ -16,61 +16,55 @@
  */
 package org.apache.camel.quarkus.component.jta.it;
 
+import java.nio.file.Paths;
 import java.util.Map;
 
 import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
+import org.apache.activemq.artemis.core.server.embedded.EmbeddedActiveMQ;
 import org.apache.camel.util.CollectionHelper;
+import org.apache.commons.io.FileUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.testcontainers.containers.GenericContainer;
-import org.testcontainers.containers.output.Slf4jLogConsumer;
-import org.testcontainers.containers.wait.strategy.Wait;
-import org.testcontainers.utility.TestcontainersConfiguration;
 
 public class ActiveMQXATestResource implements 
QuarkusTestResourceLifecycleManager {
 
     private static final Logger LOGGER = 
LoggerFactory.getLogger(ActiveMQXATestResource.class);
-    private static final String ACTIVEMQ_IMAGE = 
"vromero/activemq-artemis:2.11.0-alpine";
     private static final String ACTIVEMQ_USERNAME = "artemis";
     private static final String ACTIVEMQ_PASSWORD = "simetraehcapa";
     private static final int ACTIVEMQ_PORT = 61616;

Review comment:
       Wondering if we can randomize the port with `AvailablePortFinder`? I 
think it's possible to avoid the hard coded `broker.xml` and programmatically 
define the acceptor / connector configuration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to