[GitHub] [camel-website] djencks commented on pull request #667: Resolves #666: (Do not merge yet) Main aggregate collector/page generation

2021-11-12 Thread GitBox
djencks commented on pull request #667: URL: https://github.com/apache/camel-website/pull/667#issuecomment-967161738 > On Nov 12, 2021, at 12:40 AM, Zoran Regvart ***@***.***> wrote: > > > @zregvart approved this pull request. > > I like what this is doing, I'm a

[GitHub] [camel-website] djencks commented on pull request #667: Resolves #666: (Do not merge yet) Main aggregate collector/page generation

2021-11-11 Thread GitBox
djencks commented on pull request #667: URL: https://github.com/apache/camel-website/pull/667#issuecomment-966653008 I see what you mean. Let's discuss all this further elsewhere, I'd like to find out if there are any problems with the actual intent/main content of this set of PRs and

[GitHub] [camel-website] djencks commented on pull request #667: Resolves #666: (Do not merge yet) Main aggregate collector/page generation

2021-11-11 Thread GitBox
djencks commented on pull request #667: URL: https://github.com/apache/camel-website/pull/667#issuecomment-966625414 I suspect the linux-only deadlinks is an example of something in .yarn/cache that is architecture specific. I tried running yarn install with no network access and it

[GitHub] [camel-website] djencks commented on pull request #667: Resolves #666: (Do not merge yet) Main aggregate collector/page generation

2021-11-11 Thread GitBox
djencks commented on pull request #667: URL: https://github.com/apache/camel-website/pull/667#issuecomment-966591001 By its nature, the Antora build has to have major network access to GitHub to get the content. I can’t really tell, but it looks like rebuilding unplugged for a

[GitHub] [camel-website] djencks commented on pull request #667: Resolves #666: (Do not merge yet) Main aggregate collector/page generation

2021-11-11 Thread GitBox
djencks commented on pull request #667: URL: https://github.com/apache/camel-website/pull/667#issuecomment-966448315 What is your goal here? Is it that the jenkins build should be able to run without running yarn install? And anyone else (e.g. me with my mac) will probably have to run

[GitHub] [camel-website] djencks commented on pull request #667: Resolves #666: (Do not merge yet) Main aggregate collector/page generation

2021-11-10 Thread GitBox
djencks commented on pull request #667: URL: https://github.com/apache/camel-website/pull/667#issuecomment-965575820 The camel-kafka-connector PRs need a little more attention. The json files contain duplicate information: enum values are listed as json elements and also rendered into

[GitHub] [camel-website] djencks commented on pull request #667: Resolves #666: (Do not merge yet) Main aggregate collector/page generation

2021-11-10 Thread GitBox
djencks commented on pull request #667: URL: https://github.com/apache/camel-website/pull/667#issuecomment-965564425 Related changes: https://github.com/apache/camel/pull/6417 https://github.com/apache/camel/pull/6418 https://github.com/apache/camel-spring-boot/pull/405