Exether opened a new issue, #5112:
URL: https://github.com/apache/camel-k/issues/5112
### What happened?
While creating an Integration with an Image specified in Container, I
noticed that the corresponding Deployment created by the operator is lacking
the command line resulting in th
gansheer commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1920732956
@squakez I'll take care of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gansheer commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1930091332
While the https://github.com/apache/camel-k/pull/4831 change had the effect
to deactivate the jvm trait, it did not change the fact the use case described
here resulted to an extern
squakez commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1930308525
Yes, either we rely on the name or the presence of the "external" type
IntegrationKit would lead to the same result. The operator cannot know for sure
if a container was created by t
lburgazzoli commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1930342054
> Also changing from using the naming convention of the image to the fact
that we have an external kit would just disable the workaround given by the
naming convention check.
squakez commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1930361641
That's the way it works now. A "synthetic" kit is created after the image
name provided by the user. We may check the "external" type property to make it
more consistent, but, from a
lburgazzoli commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1930373642
> That's the way it works now. A "synthetic" kit is created after the image
name provided by the user.
This is true if you provide an image but if I remember correctly, if
gansheer commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1930401864
I think it would be better for now to :
* change the check to evaluate if the kit is external or not
* let the possibility for the user to explicitly enable the `-t
jvm.enabled
squakez closed issue #5112: Externally built Integrations are deployed without
a command in Camel-K 2.2.0
URL: https://github.com/apache/camel-k/issues/5112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
squakez commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1911650851
I think it's a side effect of https://github.com/apache/camel-k/pull/4831 In
order this to work, we check if the image was generated by a `camel-k-kit-*`
regex [1]. In your case, as
Exether commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1915530468
Thanks for the feedback.
In our use case we build the images on a specific namespace, then we retag
them for later we reuse on various namespaces. We use the project-route name
an
cazzoo commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1915534278
What about providing a variable for "camel-k-kit-" that would be overridable
per user will?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
lburgazzoli commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1915598490
@squakez is checking the name of the image really needed ? I recall that
when a container image is explicitly set, then the operator creates an
`IntegrationKit` of type `externa
lburgazzoli commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1915601232
@Exether what happens if you disable the `jvm trait` ? i.e. `kamel run -t
jvm.enabled=false`
--
This is an automated message from the Apache Git Service.
To respond to the
squakez commented on issue #5112:
URL: https://github.com/apache/camel-k/issues/5112#issuecomment-1916440359
@lburgazzoli yeah, we can try to improve the check to leverage the Kit
instead of the Integration image name. I am not 100% sure if at the time of
checking, the Kit is already availa
15 matches
Mail list logo
