[PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
tdiesler opened a new pull request, #5573: URL: https://github.com/apache/camel-k/pull/5573 **Release Note** ```release-note NONE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
claudio4j commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1624833294 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the A

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
tdiesler commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1624862817 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the Ap

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
tdiesler commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1624862817 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the Ap

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
tdiesler commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1624862817 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the Ap

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
tdiesler commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1624862817 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the Ap

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
tdiesler commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1624868846 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the Ap

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
claudio4j commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1624909641 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the A

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
tdiesler commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1625420117 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the Ap

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-03 Thread via GitHub
lburgazzoli commented on code in PR #5573: URL: https://github.com/apache/camel-k/pull/5573#discussion_r1625445606 ## e2e/knative/files/setup.sh: ## @@ -0,0 +1,244 @@ +#!/bin/bash + +# --- +# Licensed to the

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-04 Thread via GitHub
tdiesler commented on PR #5573: URL: https://github.com/apache/camel-k/pull/5573#issuecomment-2146828540 > IIUC, this would require the user to run previously the script as well, is that right? In such case I think we should update the documentation to reflect the change and let the user kn

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-04 Thread via GitHub
squakez commented on PR #5573: URL: https://github.com/apache/camel-k/pull/5573#issuecomment-2146836800 > The script is optional - if you have knative installed already, it does nothing (except to report that it already found the knative namespaces). Good, then, we better reflect this

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-04 Thread via GitHub
christophd commented on PR #5573: URL: https://github.com/apache/camel-k/pull/5573#issuecomment-2146907966 Sorry for being late to the party. I just wanted to mention the `kn-box` project that is maintained by the Knative committers: https://github.com/matzew/kn-box -- This is an automat

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-04 Thread via GitHub
tdiesler commented on PR #5573: URL: https://github.com/apache/camel-k/pull/5573#issuecomment-2147113480 rebased, please give this another shot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-04 Thread via GitHub
tdiesler commented on PR #5573: URL: https://github.com/apache/camel-k/pull/5573#issuecomment-2147494313 fails unrelated, pls try again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-04 Thread via GitHub
tdiesler commented on PR #5573: URL: https://github.com/apache/camel-k/pull/5573#issuecomment-2147608864 repeatedly fails in ``` ❌ TestOLMOperatorUpgrade (16m29.34s) ❌ TestOLMOperatorUpgrade/OLM_upgrade (10m0.03s) ``` -- This is an automated message from the Apache Git Ser

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-04 Thread via GitHub
squakez merged PR #5573: URL: https://github.com/apache/camel-k/pull/5573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apac

Re: [PR] (#5545) Add a canonical script that installs Knative [camel-k]

2024-06-04 Thread via GitHub
squakez commented on PR #5573: URL: https://github.com/apache/camel-k/pull/5573#issuecomment-2147647862 Yes, the checks were failing because it required a rebase after 2.3.2 release. Merging anyway. -- This is an automated message from the Apache Git Service. To respond to the message, pl